Bug#1057695: debian-goodies: checkrestart gives SyntaxWarning messages with python3.12

[richardn]

Package: debian-goodies
Version: 0.88.1
Severity: normal
X-Debbugs-Cc: richa...@gmail.com

python3.12 starts giving SyntaxWarning messages for invalid escape sequences in the checkrestart python script. With python3.11 these were only DeprecationWarning messages, not shown by default. According to release notes, in a future Python version SyntaxError will eventually be raised, instead of SyntaxWarning

/usr/sbin/checkrestart:222: SyntaxWarning: invalid escape sequence '\S'
m = re.match('^diversion by (\S+) (from|to): (.*)$', line)
/usr/sbin/checkrestart:398: SyntaxWarning: invalid escape sequence '\('
if re.compile("DEL").search(last) or re.compile("\(deleted\)").search(data) or re.compile("\(path inode=[0-9]+\)$").search(data):
/usr/sbin/checkrestart:398: SyntaxWarning: invalid escape sequence '\('
if re.compile("DEL").search(last) or re.compile("\(deleted\)").search(data) or re.compile("\(path inode=[0-9]+\)$").search(data):
/usr/sbin/checkrestart:430: SyntaxWarning: invalid escape sequence '\s'
if re.compile("\s\(deleted\)$").search(fname):
/usr/sbin/checkrestart:437: SyntaxWarning: invalid escape sequence '\s'
data = re.split('\s+', output.strip('\n'), 3)
/usr/sbin/checkrestart:440: SyntaxWarning: invalid escape sequence '\s'
if re.compile("\s\(deleted\)$").search(f):
/usr/sbin/checkrestart:464: SyntaxWarning: invalid escape sequence '\.'
if ( f.startswith('/lib/') or f.startswith('/usr/lib/') ) and re.compile("\.so[\d.]+$"):
/usr/sbin/checkrestart:468: SyntaxWarning: invalid escape sequence '\+'
f = re.compile("\+").sub("\+", f)
/usr/sbin/checkrestart:468: SyntaxWarning: invalid escape sequence '\+'
f = re.compile("\+").sub("\+", f)
/usr/sbin/checkrestart:469: SyntaxWarning: invalid escape sequence '\d'
f = re.compile(".so[\d.]+$").sub(".so.*", f)
/usr/sbin/checkrestart:470: SyntaxWarning: invalid escape sequence '\.'
f = re.compile("\.").sub("\.", f)
/usr/sbin/checkrestart:470: SyntaxWarning: invalid escape sequence '\.'
f = re.compile("\.").sub("\.", f)
/usr/sbin/checkrestart:594: SyntaxWarning: invalid escape sequence '\('
if re.compile("\(path inode=[0-9]+\)$").search(f):
/usr/sbin/checkrestart:651: SyntaxWarning: invalid escape sequence '\d'
re_uids = re.compile('Uid:\t(\d+)\t(\d+)\t(\d+)\t(\d+)$')
/usr/sbin/checkrestart:764: SyntaxWarning: invalid escape sequence '\('
return re.sub('( \(deleted\)|.dpkg-new).*$','',f)

Do all these need to be changed to raw strings?


-- System Information:
Debian Release: trixie/sid
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-5-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

debian-goodies depends on no packages.

Versions of packages debian-goodies recommends:
ii apt 2.7.6
ii curl 8.4.0-2
pn dctrl-tools <none>
pn elfutils <none>
pn equivs <none>
pn libfile-slurper-perl <none>
pn libfile-which-perl <none>
ii libipc-system-simple-perl 1.30-2
ii man-db 2.12.0-1
ii perl 5.36.0-10
ii popularity-contest 1.77
ii procps 2:4.0.4-2
ii python3 3.11.4-5+b1
ii sensible-utils 0.0.20
ii whiptail 0.52.24-1+b1
ii zenity 3.44.2-1

Versions of packages debian-goodies suggests:
pn apt-file <none>
pn ccze <none>
pn debsums <none>
ii firefox-esr [www-browser] 115.5.0esr-1
pn konqueror <none>
ii lsb-release 12.0-2
ii lsof 4.95.0-1
ii openssh-client 1:9.4p1-1
pn sudo <none>
ii xdg-utils 1.1.3-4.1

-- no debconf information

[Alexandre Detiste]

Hi,

Please first merge this:
https://salsa.debian.org/debian/debian-goodies/-/merge_requests/6

I've enabled CI on Salsa.

Greetings