Bug#1053033: jmol: FTBFS with default Java 21

[Vladimir Petko]

Source: jmol
Version: 14.32.83+dfsg-1
Severity: important
Tags: ftbfs
User: debia...@lists.debian.org
Usertags: default-java21
X-Debbugs-Cc: vladimi...@canonical.com

Dear Maintainers,

The package jmol ftbfs with default Java 21.
The relevant part of the build log:
---------------
classes:
[mkdir] Created dir: /<<PKGBUILDDIR>>/build/classes
[javac] Compiling 1117 source files to /<<PKGBUILDDIR>>/build/classes
[javac] warning: [options] bootstrap class path not set in conjunction with -source 7
[javac] error: Source option 7 is no longer supported. Use 8 or later.
[javac] error: Target option 7 is no longer supported. Use 8 or later.

BUILD FAILED
/<<PKGBUILDDIR>>/build.xml:451: Compile failed; see the compiler error output for details.

Total time: 0 seconds
dh_auto_build: error: ant -Duser.name debian returned exit code 1
make[1]: *** [debian/rules:52: override_dh_auto_build-indep] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:15: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2023-05-04T13:20:10Z
---------------


-- System Information:
Debian Release: bookworm/sid
APT prefers lunar-updates
APT policy: (500, 'lunar-updates'), (500, 'lunar-security'), (500, 'lunar'), (100, 'lunar-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.2.0-33-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[Emmanuel Bourg]

On Wed, 27 Sep 2023 11:03:16 +1300 Vladimir Petko <vpa...@gmail.com> wrote:

> classes:
> [mkdir] Created dir: /<<PKGBUILDDIR>>/build/classes
> [javac] Compiling 1117 source files to /<<PKGBUILDDIR>>/build/classes
> [javac] warning: [options] bootstrap class path not set in conjunction with -source 7
> [javac] error: Source option 7 is no longer supported. Use 8 or later.
> [javac] error: Target option 7 is no longer supported. Use 8 or later.

This error no longer occurs with ant/1.10.14-1, but there is another
error caused by the addLast() method in the Lst class conflicting
with the newly introduced List.addLast() method. Changing the return
type of this method should fix the issue.


[javac] /home/ebourg/packaging/jmol/src/javajs/util/Lst.java:50: error: addLast(V) in Lst cannot implement addLast(E) in List
[javac] public boolean addLast(V v) {
[javac] ^
[javac] return type boolean is not compatible with void
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in interface List
[javac] /home/ebourg/packaging/jmol/src/javajs/img/GifEncoder.java:239: error: methods addLast(V) from Lst<P3> and addLast(E) from ArrayList<P3> are inherited with the same signature
[javac] private class ColorCell extends Lst<P3> {
[javac] ^
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in class ArrayList
[javac] /home/ebourg/packaging/jmol/src/jspecview/common/MeasurementData.java:38: error: methods addLast(V) from Lst<Measurement> and addLast(E) from ArrayList<Measurement> are inherited with the same signature
[javac] public class MeasurementData extends Lst<Measurement> implements
[javac] ^
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in class ArrayList
[javac] /home/ebourg/packaging/jmol/src/jspecview/common/IntegralData.java:26: error: addLast(V) in Lst cannot implement addLast(E) in List
[javac] public class IntegralData extends MeasurementData {
[javac] ^
[javac] return type boolean is not compatible with void
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in interface List
[javac] /home/ebourg/packaging/jmol/src/jspecview/common/PeakData.java:17: error: addLast(V) in Lst cannot implement addLast(E) in List
[javac] public class PeakData extends MeasurementData {
[javac] ^
[javac] return type boolean is not compatible with void
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in interface List
[javac] /home/ebourg/packaging/jmol/src/org/jmol/smiles/SmilesRingSet.java:37: error: methods addLast(V) from Lst<SmilesRing> and addLast(E) from ArrayList<SmilesRing> are inherited with the same signature
[javac] class SmilesRingSet extends Lst<SmilesRing> {
[javac] ^
[javac] where V,E are type-variables:
[javac] V extends Object declared in class Lst
[javac] E extends Object declared in class ArrayList