Bug#1029459: hp-plugin crashes when trying to download plugin with error NameError: name 'get_distro_std_name' is not defined. Did you mean: 'get_distro_name'?

[Brian Potkin]

On Mon 23 Jan 2023 at 01:39:46 +0530, Pirate Praveen wrote:

> Package: hplip
> Version: 3.22.10+dfsg0-1
> Severity: grave
> Justification: makes it unusable
>
> $ hp-plugin
>
> HP Linux Imaging and Printing System (ver. 3.22.10)
> Plugin Download and Install Utility ver. 2.1
>
> Copyright (c) 2001-18 HP Development Company, LP
> This software comes with ABSOLUTELY NO WARRANTY.
> This is free software, and you are welcome to distribute it
> under certain conditions. See COPYING file for more details.
>
>
> HP Linux Imaging and Printing System (ver. 3.22.10)
> Plugin Download and Install Utility ver. 2.1
>
> Copyright (c) 2001-18 HP Development Company, LP
> This software comes with ABSOLUTELY NO WARRANTY.
> This is free software, and you are welcome to distribute it
> under certain conditions. See COPYING file for more details.
>
> QSocketNotifier: Can only be used with threads started with QThread
> Checking for network connection...
> Downloading plug-in from:
> Traceback (most recent call last):
> File "/usr/share/hplip/ui5/plugindialog.py", line 248, in
> NextButton_clicked
> status, download_plugin_file, error_str =
> self.pluginObj.download(self.plugin_path,self.plugin_download_callback)
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/share/hplip/installer/pluginhandler.py", line 257, in download
> core = core_install.CoreInstall()
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/share/hplip/installer/core_install.py", line 240, in __init__
> self.passwordObj = password.Password(ui_mode)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/share/hplip/base/password.py", line 94, in __init__
> self.__readAuthType() # self.__authType
> ^^^^^^^^^^^^^^^^^^^^^
> File "/usr/share/hplip/base/password.py", line 119, in __readAuthType
> distro_name = get_distro_std_name(os_name)
> ^^^^^^^^^^^^^^^^^^^
> NameError: name 'get_distro_std_name' is not defined. Did you mean:
> 'get_distro_name'?
> Aborted

Thank you for you report, Pirate Praveen.

My attempt with

sh -i hplip-3.22.10-plugin.run

failed over an ssh link. This is an upstream issue.
get_distro_std_name is not used in hplip-3.22.6.
Please report at

https://bugs.launchpad.net/hplip/+bugs

I would query the severity of grave rather than
imortant. Plugin files can be installed with

sh hplip-<version>-plugin.run --tar vxf
python3 installPlugin.py

Regards,

Brian.

[Brian Potkin]

forwarded 1029459 https://bugs.launchpad.net/hplip/+bug/2003739
thanks

> On Mon, Jan 23 2023 at 04:57:16 PM +00:00:00 +00:00:00, Brian Potkin
> <clarem...@gmail.com> wrote:

> > My attempt with
> >
> > sh -i hplip-3.22.10-plugin.run
> >
> > failed over an ssh link. This is an upstream issue.
> > get_distro_std_name is not used in hplip-3.22.6.
> > Please report at
> >
> > https://bugs.launchpad.net/hplip/+bugs
> >
>

> If you are already familiar with launchpad, can you file it?

OK.

> > I would query the severity of grave rather than
> > imortant. Plugin files can be installed with
> >
> > sh hplip-<version>-plugin.run --tar vxf
> > python3 installPlugin.py
> >
>

> Lowered severity to important. Though we probably have to document it
> somewhere more visible until this is fixed.

Thanks. The technique is not well knwn but it is viable.

Regards,

Brian.