Bug#1034003: certbot: Implement --no-random-sleep-on-renew on systemd timer

[Dan Poltawski]

Package: certbot
Version: 1.12.0-2
Severity: wishlist
Tags: patch

Dear Maintainer,

Upstream implemented a flag `--no-random-sleep-on-renew` for the use of
packagers - see https://github.com/certbot/certbot/issues/6596

The current behaviour leaves the systemd service 'activating' for more
5+ mins while the random sleep is taking place. We monitor for this
state because its often a sign of failure of services.

It's not necessary for this due to the RandomizedDelaySec in the systemd
timer itself.

It would be good to implement this option so that the service doesn't
get stuck activating for a long period of time and so i've attached a
patch.

thanks,

Dan


-- System Information:
Debian Release: 11.6
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-21-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages certbot depends on:
ii debconf [debconf-2.0] 1.5.77
ii python3 3.9.2-3
ii python3-certbot 1.12.0-2

certbot recommends no packages.

Versions of packages certbot suggests:
pn python-certbot-doc <none>
pn python3-certbot-apache <none>
pn python3-certbot-nginx <none>

-- debconf information excluded

[Harlan Lieberman-Berg]

On Thu, Apr 6, 2023 at 9:57 AM Dan Poltawski <dan.po...@tnp.net.uk> wrote:
> Upstream implemented a flag `--no-random-sleep-on-renew` for the use of
> packagers - see https://github.com/certbot/certbot/issues/6596

Well, this is embarrassing. If you look at the upstream ticket, the
person who actually requested that feature was... me. And then I just
never followed-up and put the flag in.

Whoops!

Pending upload now. :)

Sincerely,

--
Harlan Lieberman-Berg
~hlieberman