Bug#1005411: deluge: log spammed with findCaller exception

[Daniel Gröber]

Package: deluge
Severity: wishlist

Dear Maintainer,

as soon as deluged is started on my system the log is spammed with the
following exception.

Unhandled error in Deferred:
23:49:08 [CRITICAL][twisted :154 ] Unhandled error in Deferred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/deluge/core/torrentmanager.py", line 697, in add_async_callback
torrent = self._add_torrent_obj(
File "/usr/lib/python3/dist-packages/deluge/core/torrentmanager.py", line 668, in _add_torrent_obj
log.info(
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 1613, in unwindGenerator
return _cancellableInlineCallbacks(gen)
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
_inlineCallbacks(None, g, status)
--- <exception caught here> ---
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
result = g.send(result)
File "/usr/lib/python3/dist-packages/deluge/log.py", line 69, in info
yield LoggingLoggerClass.info(self, msg, *args, **kwargs)
File "/usr/lib/python3.9/logging/__init__.py", line 1442, in info
self._log(INFO, msg, args, **kwargs)
File "/usr/lib/python3.9/logging/__init__.py", line 1573, in _log
fn, lno, func, sinfo = self.findCaller(stack_info, stacklevel)
builtins.TypeError: findCaller() takes from 1 to 2 positional arguments but 3 were given
Temporarily disabling observer LegacyLogObserverWrapper(<bound method TwistedLoggingObserver.emit of <deluge.log.TwistedLoggingObserver object at 0x7fe3>
/usr/lib/python3/dist-packages/deluge/core/torrent.py:1129:_create_status_funcs
/usr/lib/python3/dist-packages/twisted/internet/defer.py:962:__del__
/usr/lib/python3/dist-packages/twisted/logger/_logger.py:190:failure
/usr/lib/python3/dist-packages/twisted/logger/_logger.py:144:emit
--- <exception caught here> ---
/usr/lib/python3/dist-packages/twisted/logger/_observer.py:131:__call__
/usr/lib/python3/dist-packages/twisted/logger/_legacy.py:93:__call__
/usr/lib/python3/dist-packages/deluge/log.py:204:emit
/usr/lib/python3.9/logging/__init__.py:1489:critical
/usr/lib/python3.9/logging/__init__.py:1573:_log
]

There is an upstream commit that fixes this problem, please include it in
the Debian package.

https://git.deluge-torrent.org/deluge/commit/?h=develop&id=351664ec071daa04161577c6a1c949ed0f2c3206

Thanks,
--Daniel

-- System Information:
Debian Release: 11.1
APT prefers stable
APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'stable-security')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-9-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[Olivier Allard-Jacquin]

Dear Maintainer,

same issue here (Debian Testing / amd64 / up to date), after python
3.10 to 3.11 standard Debian Testing upgrade.

In order to fix it, I've to apply 2 patchs:
- Same as Daniel from current bug #1005411 :
https://git.deluge-torrent.org/deluge/commit/?h=develop&id=351664ec071daa04161577c6a1c949ed0f2c3206

- And a second patch, found here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016044
https://github.com/deluge-torrent/deluge/commit/89189adb24321c3db6bfa816ec557d7d8367ba24

Run deluged during 12h, no more abnormal messages into journal

Thanks for your help.

Best regards,
Olivier

[Daniel Baumann]

close 1005411 2.1.1-1
thanks

Hi,

thank you for reporting this, the referenced fixes are included in the
2.1.1 version, hence closing the bug.

Regards,
Daniel