Bug#1003699: libfido2-dev: missing dependency on libssl-dev breaks pkg-config

[Luca Boccassi]

Package: libfido2-dev
Version: 1.9.0-1
Tags: patch

While adding libfido2-dev as a dependency to src:systemd, we noticed
that it fails to build if libssl-dev is not installed, because
libfido2.pc lists:

Requires: libcrypto

So pkg-config --cflags --libs libfido2 breaks:

pkg-config error with 'libfido2': Could not generate cargs for libfido2:
Package libcrypto was not found in the pkg-config search path.
Perhaps you should add the directory containing `libcrypto.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libcrypto', required by 'libfido2', not found

Could not generate cargs for libfido2:
Package libcrypto was not found in the pkg-config search path.
Perhaps you should add the directory containing `libcrypto.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libcrypto', required by 'libfido2', not found

libssl-dev is currently suggested, so it should be bumped to a dependency.

MR submitted on Salsa:

https://salsa.debian.org/auth-team/libfido2/-/merge_requests/5

Kind regards,
Luca Boccassi

[Michael Biebl]

On Thu, 13 Jan 2022 20:55:45 +0000 Luca Boccassi <bl...@debian.org> wrote:
> Package: libfido2-dev
> Version: 1.9.0-1
> Tags: patch
>
> While adding libfido2-dev as a dependency to src:systemd, we noticed
> that it fails to build if libssl-dev is not installed, because
> libfido2.pc lists:
>
> Requires: libcrypto
>
> So pkg-config --cflags --libs libfido2 breaks:
>
> pkg-config error with 'libfido2': Could not generate cargs for libfido2:
> Package libcrypto was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libcrypto.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'libcrypto', required by 'libfido2', not found
>
> Could not generate cargs for libfido2:
> Package libcrypto was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libcrypto.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'libcrypto', required by 'libfido2', not found
>
> libssl-dev is currently suggested, so it should be bumped to a dependency.

Without having looked at libfido2, an alternative might be the usage of
Requires.private

"Requires.private: A list of private packages required by this package
but not exposed to applications. The version specific rules from the
Requires field also apply here."

IIRC, Requires.private dependencies are not required for determining CFLAGS.

Regards,
Michael