Bug#1016505: patch: Fix `Incorrect netdev->dev_addr` errors in linux-5.17+ patch

[Diego Escalante Urrelo]

Source: broadcom-sta
Version: 6.30.223.271-20
Severity: important
Tags: patch
X-Debbugs-Cc: die...@gnome.org

Dear Maintainer,

The patch for linux-5.17 deprecations incorrectly inverted the src/dest
of the copying of MAC addresses.

I have pushed a branch with the gbp-processed patch:
https://salsa.debian.org/diegoe/broadcom-sta/-/tree/debian-diegoe-202208

I _think_ this potentially fixes two recent bugs that have the trace/bug
in the logs, but my card is a different PHY so I can't confirm that.

Here's the commit log for further explanation:

```
d/patches: Fix the linux-5.17 deprecations patch

The patch was enough to get things to build, but it accidentally
inverted the direction of the copy of a few addresses.

This was causing traces when the device address was set in the driver:

```
wl 0000:03:00.0 wlp3s0: Current addr: NN NN NN NN NN NN 00 00 00 00 00 00 00 00 00
wl 0000:03:00.0 wlp3s0: Expected addr: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
------------[ cut here ]------------
netdevice: wlp3s0: Incorrect netdev->dev_addr
WARNING: CPU: 3 PID: 1178 at net/core/dev_addr_lists.c:517 dev_addr_check.cold+0x43/0x7d
(...)
```

(where NN is the device MAC)

Apparently this might be enough in some cards to make it impossible to
connect to a network. See bugs below.

See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011529
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016426
```

-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[Diego Escalante Urrelo]

Package: broadcom-sta-dkms
Version: 6.30.223.271-22
Followup-For: Bug #1016505
X-Debbugs-Cc: die...@gnome.org

Bump.

I have pushed this and other fixes as a branch in salsa:
https://salsa.debian.org/diegoe/broadcom-sta/-/commits/2022-various-fixes

At least the patch in this bug report is important, the other stuff is
mostly lintian warnings and nitpicks.

Thanks!

-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en

Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages broadcom-sta-dkms depends on:
ii dkms 3.0.6-4

Versions of packages broadcom-sta-dkms recommends:
ii wireless-tools 30~pre9-13.1

broadcom-sta-dkms suggests no packages.

-- no debconf information

[Eduard Bloch]

Am Thu, Nov 10, 2022 at 12:08:31PM -0500 schrieb Diego Escalante Urrelo:
> Package: broadcom-sta-dkms
> Version: 6.30.223.271-22
> Followup-For: Bug #1016505
> X-Debbugs-Cc: die...@gnome.org
>
> Bump.
>
> I have pushed this and other fixes as a branch in salsa:
> https://salsa.debian.org/diegoe/broadcom-sta/-/commits/2022-various-fixes

Thank you. I am on it. Brief test on Linux 6.1 staging branch shows no warnings.

Best regars,
Eduard.