Bug#1001628: scap-workbench: FTBFS: error: ‘QString::SkipEmptyParts’ is deprecated [-Werror=deprecated-declarations]

[Andreas Beckmann]

Source: scap-workbench
Version: 1.2.1-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Hi,

src:scap-workbench FTBFS everywhere due to usage of deprecated bits and
-Werror=deprecated-declarations:

https://buildd.debian.org/status/package.php?p=scap-workbench&suite=experimental

[ 51%] Building CXX object CMakeFiles/scap-workbench.dir/src/OscapCapabilities.cpp.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XMLPATTERNS_LIB -I/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/scap-workbench_autogen/include -I/<<PKGBUILDDIR>>/include -I/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu -I/usr/include/openscap -isystem /usr/include/aarch64-linux-gnu/qt5 -isystem /usr/include/aarch64-linux-gnu/qt5/QtWidgets -isystem /usr/include/aarch64-linux-gnu/qt5/QtGui -isystem /usr/include/aarch64-linux-gnu/qt5/QtCore -isystem /usr/lib/aarch64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/aarch64-linux-gnu/qt5/QtXmlPatterns -isystem /usr/include/aarch64-linux-gnu/qt5/QtNetwork -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Werror -fPIC -MD -MT CMakeFiles/scap-workbench.dir/src/OscapCapabilities.cpp.o -MF CMakeFiles/scap-workbench.dir/src/OscapCapabilities.cpp.o.d -o CMakeFiles/scap-workbench.dir/src/OscapCapabilities.cpp.o -c /<<PKGBUILDDIR>>/src/OscapCapabilities.cpp
/<<PKGBUILDDIR>>/src/OscapCapabilities.cpp: In member function ‘void OscapCapabilities::parse(const QString&)’:
/<<PKGBUILDDIR>>/src/OscapCapabilities.cpp:89:64: error: ‘QString::SkipEmptyParts’ is deprecated [-Werror=deprecated-declarations]
89 | const QStringList firstLine = lines[0].split(' ', QString::SkipEmptyParts);
| ^~~~~~~~~~~~~~
In file included from /usr/include/aarch64-linux-gnu/qt5/QtCore/QString:1,
from /<<PKGBUILDDIR>>/include/OscapCapabilities.h:27,
from /<<PKGBUILDDIR>>/src/OscapCapabilities.cpp:22:
/usr/include/aarch64-linux-gnu/qt5/QtCore/qstring.h:605:9: note: declared here
605 | SkipEmptyParts Q_DECL_ENUMERATOR_DEPRECATED
| ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/OscapCapabilities.cpp:89:64: error: ‘QString::SkipEmptyParts’ is deprecated [-Werror=deprecated-declarations]
89 | const QStringList firstLine = lines[0].split(' ', QString::SkipEmptyParts);
| ^~~~~~~~~~~~~~
In file included from /usr/include/aarch64-linux-gnu/qt5/QtCore/QString:1,
from /<<PKGBUILDDIR>>/include/OscapCapabilities.h:27,
from /<<PKGBUILDDIR>>/src/OscapCapabilities.cpp:22:
/usr/include/aarch64-linux-gnu/qt5/QtCore/qstring.h:605:9: note: declared here
605 | SkipEmptyParts Q_DECL_ENUMERATOR_DEPRECATED
| ^~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [CMakeFiles/scap-workbench.dir/build.make:219: CMakeFiles/scap-workbench.dir/src/OscapCapabilities.cpp.o] Error 1

Andreas

[Håvard F. Aasen]

Control: tags -1 + fixed-upstream


Hi,

Because of the '-Werror' flag this ftbfs because of an deprecation
warning from Qt5, this is fixed upstream [1]. When that's fixed, the
build triggers a second error:

/<<PKGBUILDDIR>>/src/MainWindow.cpp: In member function ‘void MainWindow::openFile(const QString&, bool)’:
/<<PKGBUILDDIR>>/src/MainWindow.cpp:412:28: error: loop variable ‘path’ creates a copy from type ‘const QString’ [-Werror=range-loop-construct]
412 | for (const QString path : mScanningSession->getOriginalClosure())
| ^~~~
/<<PKGBUILDDIR>>/src/MainWindow.cpp:412:28: note: use reference type to prevent copying
412 | for (const QString path : mScanningSession->getOriginalClosure())
| ^~~~
| &

This is also fixed upstream [2].

Would it make sense to remove the '-Werror' flag? A lot of these errors
are really pedantic and in my opinion shouldn't make the build fail.


Regards,
Håvard



[1] https://github.com/OpenSCAP/scap-workbench/commit/c4a7616b9c61acee077359e71db2b3ab4db8098b
[2] https://github.com/OpenSCAP/scap-workbench/commit/51c0b300b0b1a0194628c4b84bb35885b21663ab