Bug#1059573: golang-opentelemetry-contrib-dev: Upload to unstable

[M Hickford]

Package: golang-opentelemetry-contrib-dev
Version: 0.25.0-1
Severity: wishlist
X-Debbugs-Cc: mirth.h...@gmail.com

Dear Maintainer,

Please consider uploading your package to unstable

[Maytham Alsudany]

Hi Thomas,

Would you consider updating golang-opentelemetry-contrib to 1.22.0 and uploading
it to unstable rather than experimental? Is there an issue preventing an upload
to unstable?

The lack of an up-to-date golang-opentelemetry-contrib package in unstable is
blocking updating golang-google-api to 0.157.0 (#1059573).

Kind regards,
Maytham

[Simon Josefsson]

Hi.

I was looking at golang-opentelemetry-contrib-dev because it is needed
for etcd 3.5.x. It seems to build fine, but upstream is doing several
concurrent releases, and we don't have the latest version in
experimental. I wanted to upgrade it to the latest upstream version
before doing an upload.

Upstream etcd 3.4.x does not need golang-opentelemetry-contrib-dev.

Upstream etcd 3.5.11 (latest 3.5.x release) seems to use v0.46.0:

jas@kaka:~/src/etcd$ git status
HEAD detached at v3.5.11
nothing to commit, working tree clean
jas@kaka:~/src/etcd$ grep opentelemetry $(find . -name go.mod)|grep contrib
./etcdctl/go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 // indirect
./server/go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0
./etcdutl/go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 // indirect
./tests/go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0
./go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 // indirect
jas@kaka:~/src/etcd$

So I think we should upload v0.46.0 to unstable?

/Simon

[Maytham Alsudany]

Hi Simon,

On Wed, 2024-01-24 at 10:03 +0100, Simon Josefsson wrote:
> Hi.
>
> I was looking at golang-opentelemetry-contrib-dev because it is needed
> for etcd 3.5.x. It seems to build fine, but upstream is doing several
> concurrent releases, and we don't have the latest version in
> experimental. I wanted to upgrade it to the latest upstream version
> before doing an upload.
>
> Upstream etcd 3.4.x does not need golang-opentelemetry-contrib-dev.
>
> Upstream etcd 3.5.11 (latest 3.5.x release) seems to use v0.46.0:

etcd 3.5.11 uses v0.46.1 of the instrumentation/google.golang.org/grpc/otelgrpc
module, which is versioned differently to the overall package. etcd actually needs
golang-opentelemetry-contrib-dev >= 1.21.1.

So I think it's best to update golang-opentelemetry-contrib to the latest version.

Kind regards,
Maytham

[Simon Josefsson]

Yeah, alas, golang-opentelemetry-contrib needs newer
golang-opentelemetry-otel, otherwise you get build errors like this:

src/go.opentelemetry.io/contrib/config/trace.go:13:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc" in any of:
/usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOROOT)
/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOPATH)
src/go.opentelemetry.io/contrib/config/trace.go:14:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" in any of:
/usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOROOT)
/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOPATH)
src/go.opentelemetry.io/contrib/config/trace.go:19:2: cannot find package "go.opentelemetry.io/otel/trace/noop" in any of:
/usr/lib/go-1.21/src/go.opentelemetry.io/otel/trace/noop (from $GOROOT)
/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/trace/noop (from $GOPATH)
src/go.opentelemetry.io/contrib/propagators/opencensus/binary.go:22:2: cannot find package "go.opentelemetry.io/otel/bridge/opencensus" in any of:
/usr/lib/go-1.21/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOROOT)
/build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOPATH)

To have confidence in an update of otel, I first built reverse
dependencies of otel in sid but there are failures:

https://salsa.debian.org/jas/golang-opentelemetry-otel/-/pipelines/629791

I think this really indicate FTBFS bugs in cadvisor, crowdsec, and
gitlab-ci-multi-runner? Rebuilding packages in sid should work.

I will try to update otel to 1.23.0-rc.1 and see if I get it to build.
Build failures on the three previous packages can be probably be
attributed to FTBFS bugs in those three packages, rathern than
incompatibility with otel 1.23.0-rc1. But you don't know for certain...

/Simon

[Maytham Alsudany]

Hi Simon,

On Wed, 2024-01-24 at 11:41 +0100, Simon Josefsson wrote:
> Yeah, alas, golang-opentelemetry-contrib needs newer
> golang-opentelemetry-otel, otherwise you get build errors like this:
>
> src/go.opentelemetry.io/contrib/config/trace.go:13:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc" in any of:
> /usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOROOT)
> /build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc (from $GOPATH)
> src/go.opentelemetry.io/contrib/config/trace.go:14:2: cannot find package "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" in any of:
> /usr/lib/go-1.21/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOROOT)
> /build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (from $GOPATH)
> src/go.opentelemetry.io/contrib/config/trace.go:19:2: cannot find package "go.opentelemetry.io/otel/trace/noop" in any of:
> /usr/lib/go-1.21/src/go.opentelemetry.io/otel/trace/noop (from $GOROOT)
> /build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/trace/noop (from $GOPATH)
> src/go.opentelemetry.io/contrib/propagators/opencensus/binary.go:22:2: cannot find package "go.opentelemetry.io/otel/bridge/opencensus" in any of:
> /usr/lib/go-1.21/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOROOT)
> /build/golang-opentelemetry-contrib-0.47.0/obj-x86_64-linux-gnu/src/go.opentelemetry.io/otel/bridge/opencensus (from $GOPATH)
>
> To have confidence in an update of otel, I first built reverse
> dependencies of otel in sid but there are failures:
>
> https://salsa.debian.org/jas/golang-opentelemetry-otel/-/pipelines/629791
>
> I think this really indicate FTBFS bugs in cadvisor, crowdsec, and
> gitlab-ci-multi-runner? Rebuilding packages in sid should work.

I'll open bugs and try fix them when time permits.

> I will try to update otel to 1.23.0-rc.1 and see if I get it to build.
> Build failures on the three previous packages can be probably be
> attributed to FTBFS bugs in those three packages, rathern than
> incompatibility with otel 1.23.0-rc1. But you don't know for certain...

Isn't 1.23.0-rc1 a pre-release? Sounds like d/watch needs to be fixed.
As soon as you get golang-opentelemetry-otel 1.23.0 building, could you please
upload it to experimental so I can build fixed packages against the new version?

BTW, thanks for the Salsa pipelines, they're very helpful in finding the
problems.

--
Kind regards,
Maytham (@Maytha8)