Bug#1040377: libmime-tools-perl: spurious warning with Perl 5.38

[Niko Tyni]

Package: libmime-tools-perl
Version: 5.510-1
Severity: normal
Tags: trixie sid
User: debia...@lists.debian.org
Usertags: perl-5.38-transition

The MIME::Decoder::QuotedPrint module throws a warning on usage
with Perl 5.38 (currently in experimental):

$ perl -w -e 'use MIME::Decoder::QuotedPrint'
Argument "3.16_01" isn't numeric in numeric ge (>=) at /usr/share/perl5/MIME/Decoder/QuotedPrint.pm line 76.

This is because Perl core includes MIME::QuotedPrint at version 3.16_01,
and MIME::Decoder::QuotedPrint has this:

# The following code is horrible. I know. Beat me up. --dfs
BEGIN {
if (!defined(&encode_qp_threearg)) {
if ($::MIME::QuotedPrint::VERSION >= 3.03) {
eval 'sub encode_qp_threearg ( $$$ ) { encode_qp(shift, shift, shift); }';
} else {
eval 'sub encode_qp_threearg ( $$$ ) { encode_qp(shift); }';
}
}
}

Looks like the version check needs to be changed to handle non-numeric
version strings.

This is breaking the test suites of (at least) request-tracker4 and
request-tracker5, which check for warnings.
--
Niko Tyni nt...@debian.org

[Niko Tyni]

Control: tag -1 patch

On Wed, Jul 05, 2023 at 10:23:45AM +0300, Niko Tyni wrote:
> Package: libmime-tools-perl
> Version: 5.510-1
> Severity: normal
> Tags: trixie sid
> User: debia...@lists.debian.org
> Usertags: perl-5.38-transition
>
> The MIME::Decoder::QuotedPrint module throws a warning on usage
> with Perl 5.38 (currently in experimental):
>
> $ perl -w -e 'use MIME::Decoder::QuotedPrint'
> Argument "3.16_01" isn't numeric in numeric ge (>=) at /usr/share/perl5/MIME/Decoder/QuotedPrint.pm line 76.

> Looks like the version check needs to be changed to handle non-numeric
> version strings.

Trivial patch attached.
--
Niko Tyni nt...@debian.org