Bug#1012049: photofilmstrip: unable to add pictures

[Gravis]

Package: photofilmstrip
Version: 3.7.3-2
Severity: important
X-Debbugs-Cc: noreply+debian.repo...@adaptivetime.com

Dear Maintainer,

* What led up to the situation?
Run program (GUI mode), create new project, add picture.

* What was the outcome of this action?
Program throws an uncaught exception before hanging:

File "/home/gravis/pfs/photofilmstrip/gui/ImageSectionEditor.py", line 481, in
OnResize
self.__Scale()
File "/home/gravis/pfs/photofilmstrip/gui/ImageSectionEditor.py", line 122,
in __Scale
self._imgProxy.Scale(newWidth, newHeight)
File "/home/gravis/pfs/photofilmstrip/gui/ImageSectionEditor.py", line 675,
in Scale
img = self._wxImg.Scale(width, height)
TypeError: Image.Scale(): argument 1 has unexpected type 'float'


-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.16.0-6-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages photofilmstrip depends on:
ii gstreamer1.0-libav 1.20.2-1
ii libjs-sphinxdoc 4.5.0-3
ii python3 3.10.4-1+b1
ii python3-gst-1.0 1.20.2-1
ii python3-pil 9.1.0-1
ii python3-wxgtk4.0 4.0.7+dfsg-13

photofilmstrip recommends no packages.

photofilmstrip suggests no packages.

[PhotoFilmStrip]

Hi,

thanks for reporting this.
It looks like you running PhotoFilmStrip from source. Whats your
environment you running it on? Especially python version and wxPython
version? As a quick fix you might edit the file
"/home/gravis/pfs/photofilmstrip/gui/ImageSectionEditor.py" on line 675.
Change the line:
img = self._wxImg.Scale(width, height)
to
img = self._wxImg.Scale(int(round(width)), int(round(height)))

I have a look at the issue myself and try to publish a fix.

Regards,
Jens








Zitat von Gravis
<noreply+debian.repo...@adaptivetime.com> (So 29 Mai
2022 13:31:37 CEST):

[Philipp Huebner]

Hi,

I can confirm this bug on current Debian Sid, Python 3.10 and
python3-wxgtk4.0 4.0.7.

Am 04.06.22 um 10:24 schrieb PhotoFilmStrip:

> As a quick fix you might edit the file
> "/home/gravis/pfs/photofilmstrip/gui/ImageSectionEditor.py" on line 675.
> Change the line:
> img = self._wxImg.Scale(width, height)
> to
> img = self._wxImg.Scale(int(round(width)), int(round(height)))

I tried that fix, it solves that issue but then another one pops up:

Traceback (most recent call last):
File
"/usr/lib/python3/dist-packages/photofilmstrip/gui/PnlPfsProject.py",
line 501, in OnLvPicsSelectionChanged
self._OnPicsSelectionChanged(selItems, selPics)
File
"/usr/lib/python3/dist-packages/photofilmstrip/gui/PnlSlideshow.py",
line 127, in _OnPicsSelectionChanged
self.bitmapLeft.SetSection(wx.Rect(*selPics[0].GetStartRect()))
TypeError: Rect(): arguments did not match any overloaded call:
overload 1: too many arguments
overload 2: argument 2 has unexpected type 'float'
overload 3: argument 1 has unexpected type 'int'
overload 4: argument 1 has unexpected type 'int'
overload 5: argument 1 has unexpected type 'int'
overload 6: argument 1 has unexpected type 'int'
Traceback (most recent call last):
File
"/usr/lib/python3/dist-packages/photofilmstrip/gui/ImageSectionEditor.py",
line 221, in OnPaint
self.__DrawSection(dc)
File
"/usr/lib/python3/dist-packages/photofilmstrip/gui/ImageSectionEditor.py",
line 150, in __DrawSection
sectRect = self.__SectRectToClientRect()
File
"/usr/lib/python3/dist-packages/photofilmstrip/gui/ImageSectionEditor.py",
line 140, in __SectRectToClientRect
sectRect = wx.Rect(left + (self._sectRect.GetLeft() * self._zoom),
TypeError: Rect(): arguments did not match any overloaded call:
overload 1: too many arguments
overload 2: argument 1 has unexpected type 'float'
overload 3: argument 1 has unexpected type 'float'
overload 4: argument 1 has unexpected type 'float'
overload 5: argument 1 has unexpected type 'float'
overload 6: argument 1 has unexpected type 'float'

> I have a look at the issue myself and try to publish a fix.

Please ping me when that's done.


Best wishes
--
.''`. Philipp Huebner <deba...@debian.org>
: :' : pgp fp: 6719 25C5 B8CD E74A 5225 3DF9 E5CA 8C49 25E4 205F
`. `'`
`-