Bug#1026025: pyspf-milter seems to ignore configured parameters

[Pascal Volk]

Package: pyspf-milter
Version: 3.0.1-1
Severity: important
X-Debbugs-Cc: vo...@demos-deutschland.de



Hi Scott,

my `pyspf-milter.conf` has the following three lines:

skip_addresses = 127.0.0.0/8,::ffff:127.0.0.0/104,::1
InternalHosts = 127.0.0.1,::1
Hide_Receiver = No

It looks looks like as pyspf-milter would ignore at least the
parameters `InternalHosts' and `Hide_Receiver'. Thus the log
contains lines like:

pyspf-milter[43325]: connect from localhost at ('::1', 39792, 0, 0) EXTERNAL
pyspf-milter[43325]: prepend Authentication-Results: $HOST; none (SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=root@$HOST.example.com; receiver=<UNKNOWN>

Please let me know if you need further details.


Best Regards,
Pascal


-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (500, 'testing'), (50, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-5-amd64 (SMP w/1 CPU thread; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages pyspf-milter depends on:
ii adduser 3.129
ii init-system-helpers 1.65.2
ii postfix 3.7.3-2+b1
ii python3 3.10.6-1
ii python3-milter 1.0.5-1+b2
ii python3-pkg-resources 65.5.0-1
ii python3-spf-engine 3.0.1-1

pyspf-milter recommends no packages.

pyspf-milter suggests no packages.

-- no debconf information

[Scott Kitterman]

On Tue, 13 Dec 2022 23:54:17 -0500 Scott Kitterman <deb...@kitterman.com>
wrote:

> On Tue, 13 Dec 2022 13:36:29 +0100 Pascal Volk <vo...@demos-deutschland.de>
> wrote:
> > Package: pyspf-milter
> > Version: 3.0.1-1
> > Severity: important
> > X-Debbugs-Cc: vo...@demos-deutschland.de
> >
> >
> >
> > Hi Scott,
> >
> > my `pyspf-milter.conf` has the following three lines:
> >
> > skip_addresses = 127.0.0.0/8,::ffff:127.0.0.0/104,::1
> > InternalHosts = 127.0.0.1,::1
> > Hide_Receiver = No
> >
> > It looks looks like as pyspf-milter would ignore at least the
> > parameters `InternalHosts' and `Hide_Receiver'. Thus the log
> > contains lines like:
> >
> > pyspf-milter[43325]: connect from localhost at ('::1', 39792, 0,
0)
> EXTERNAL
> > pyspf-milter[43325]: prepend Authentication-Results: $HOST; none
> (SPF check N/A for local connections - client-ip=::1; helo=localhost;
> envelope-from=root@$HOST.example.com; receiver=<UNKNOWN>
> >
> > Please let me know if you need further details.
>

> Thanks. That should be enough for me to investigate.
>
> So far it looks like a combination of things.

There are two problems. One is architectural and the other is a bug.

I have confirmed that the configuration file is being read correctly.

The architectural issue is that the milter does the SPF check right after rcpt
to in the SMTP session, so the receiver is unknown. As a result, the receiver
will be unknown regardless of the Hide_Receiver setting. This should be
addressed in the documentation so it's clear.

InternalHosts is not working correctly, so that's an actual bug.

Scott K

[Scott Kitterman]

On Wednesday, December 14, 2022 11:53:04 AM EST Scott Kitterman wrote:

> The architectural issue is that the milter does the SPF check right after
> rcpt to in the SMTP session, so the receiver is unknown. As a result, the
> receiver will be unknown regardless of the Hide_Receiver setting. This
> should be addressed in the documentation so it's clear.

^^^ should be after mail from