Bug#993016: libdap: Includes rpc/types.h which is no longer provided by libc6-dev

[Sebastiaan Couwenberg]

On 8/31/21 10:02 AM, Aurelien Jarno wrote:
> On 2021-08-30 23:07, Aurelien Jarno wrote:
>> On 2021-08-30 20:15, Sebastiaan Couwenberg wrote:
>>> On 8/27/21 12:14 PM, Aurelien Jarno wrote:
>>>> On 2021-08-26 13:27, Bas Couwenberg wrote:
>>>>> The recent changes in glibc break libdap and its rdeps:
>>>>>
>>>>> In file included from /usr/include/libdap/XDRUtils.h:37,
>>>>> from /usr/include/libdap/Sequence.h:50,
>>>>> from libdap_headers.h:52,
>>>>> from ogr_dods.h:44,
>>>>> from ogrdodsdriver.cpp:29:
>>>>> /usr/include/libdap/xdr-datatypes.h:16:10: fatal error: rpc/types.h: No such file or directory
>>>>> 16 | #include <rpc/types.h>
>>>>> | ^~~~~~~~~~~~~
>>>>>
>>>>> /usr/include/rpc/types.h was provided by libc6-dev in bullseye, but it is no longer included in libc6-dev (2.31-17).
>>>>
>>>> The problem is that libdap has proper TI RPC support, but it doesn't
>>>> export that information properly to libdap.pc and dap-config, sorry
>>>> about that.
>>>>
>>>> Please find a patch attached to fix that.
>>>
>>> Thanks for the patch, I've prepared an NMU with it applied.
>>>
>>> I can confirm that it fixes the libdap issue breaking the gdal build.
>>> Unfortunately ecs.h from ogdi-dfsg still includes rpc/rpc.h also
>>> breaking the gdal build.
>>
>> It's normal keeps including rpc/rpc.h, but it should get its cflags
>> updated. It has just been binNMUed today, and with libogdi-dev version
>> 4.1.0+ds-5+b1, I get:
>>
>> $ /usr/bin/ogdi-config --cflags
>> -I/usr/include/ogdi -I/usr/include/tirpc
>> $ pkg-config --cflags ogdi
>> -I/usr/include/ogdi -I/usr/include/tirpc
>>
>> So that should be fixed already.
>
> In pratice it doesn't work due to an issue with the gdal packaging. The
> patch debian/patches/ogdi should be dropped.

Thanks for looking into this, I came to the same conclusion this morning:

https://github.com/OSGeo/gdal/pull/4394#issuecomment-908892817

That just leave this libdap issue as a blocker.

Kind Regards,

Bas

--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1