Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#919509: systemd packaging does not touch /var/run/reboot-required
15 views
Skip to first unread message
Karl O. Pinc
Jan 16, 2019, 1:50:03 PM1/16/19
to
Package: systemd
Version: 232-25+deb9u8
Severity: normal
Hi,
systemd security updates to stable
systemd (232-25+deb9u8) stretch-security; urgency=high
systemd (232-25+deb9u7) stretch-security; urgency=high
required reboot to take effect, but /var/run/reboot-required
was not `touch`ed. Therefore the unattended-upgrades
package did not notify the user that a reboot is required.
(There were related upgrades to udev and other packages.)
There are probably many systems which installed the
upgrade automatically but did not reboot and so the
patch did not take effect.
"The Internet" says that it is the postinst script which
should touch /var/run/reboot-required.
There is also a (new) bug against debian-policy because
policy does not mention the mechanism:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919507
See also:
https://sources.debian.org/src/unattended-upgrades/1.9/unattended-upgrade/#L83
Regards,
Karl
-- Package-specific info:
-- System Information:
Debian Release: 9.6
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages systemd depends on:
ii adduser 3.115
ii libacl1 2.2.52-3+b1
ii libapparmor1 2.11.0-3+deb9u2
ii libaudit1 1:2.6.7-2
ii libblkid1 2.29.2-1+deb9u1
ii libc6 2.24-11+deb9u3
ii libcap2 1:2.25-1
ii libcryptsetup4 2:1.7.3-4
ii libgcrypt20 1.7.6-2+deb9u3
ii libgpg-error0 1.26-2
ii libidn11 1.33-1
ii libip4tc0 1.6.0+snapshot20161117-6
ii libkmod2 23-2
ii liblz4-1 0.0~r131-2+b1
ii liblzma5 5.2.2-1.2+b1
ii libmount1 2.29.2-1+deb9u1
ii libpam0g 1.1.8-3.6
ii libseccomp2 2.3.1-2.1+deb9u1
ii libselinux1 2.6-3+b3
ii libsystemd0 232-25+deb9u8
ii mount 2.29.2-1+deb9u1
ii procps 2:3.3.12-3+deb9u1
ii util-linux 2.29.2-1+deb9u1
Versions of packages systemd recommends:
ii dbus 1.10.26-0+deb9u1
ii libpam-systemd 232-25+deb9u8
Versions of packages systemd suggests:
ii policykit-1 0.105-18+deb9u1
pn systemd-container <none>
pn systemd-ui <none>
Versions of packages systemd is related to:
pn dracut <none>
ii initramfs-tools 0.130
ii udev 232-25+deb9u8
-- no debconf information
Version: 232-25+deb9u8
Severity: normal
Hi,
systemd security updates to stable
systemd (232-25+deb9u8) stretch-security; urgency=high
systemd (232-25+deb9u7) stretch-security; urgency=high
required reboot to take effect, but /var/run/reboot-required
was not `touch`ed. Therefore the unattended-upgrades
package did not notify the user that a reboot is required.
(There were related upgrades to udev and other packages.)
There are probably many systems which installed the
upgrade automatically but did not reboot and so the
patch did not take effect.
"The Internet" says that it is the postinst script which
should touch /var/run/reboot-required.
There is also a (new) bug against debian-policy because
policy does not mention the mechanism:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919507
See also:
https://sources.debian.org/src/unattended-upgrades/1.9/unattended-upgrade/#L83
Regards,
Karl
-- Package-specific info:
-- System Information:
Debian Release: 9.6
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages systemd depends on:
ii adduser 3.115
ii libacl1 2.2.52-3+b1
ii libapparmor1 2.11.0-3+deb9u2
ii libaudit1 1:2.6.7-2
ii libblkid1 2.29.2-1+deb9u1
ii libc6 2.24-11+deb9u3
ii libcap2 1:2.25-1
ii libcryptsetup4 2:1.7.3-4
ii libgcrypt20 1.7.6-2+deb9u3
ii libgpg-error0 1.26-2
ii libidn11 1.33-1
ii libip4tc0 1.6.0+snapshot20161117-6
ii libkmod2 23-2
ii liblz4-1 0.0~r131-2+b1
ii liblzma5 5.2.2-1.2+b1
ii libmount1 2.29.2-1+deb9u1
ii libpam0g 1.1.8-3.6
ii libseccomp2 2.3.1-2.1+deb9u1
ii libselinux1 2.6-3+b3
ii libsystemd0 232-25+deb9u8
ii mount 2.29.2-1+deb9u1
ii procps 2:3.3.12-3+deb9u1
ii util-linux 2.29.2-1+deb9u1
Versions of packages systemd recommends:
ii dbus 1.10.26-0+deb9u1
ii libpam-systemd 232-25+deb9u8
Versions of packages systemd suggests:
ii policykit-1 0.105-18+deb9u1
pn systemd-container <none>
pn systemd-ui <none>
Versions of packages systemd is related to:
pn dracut <none>
ii initramfs-tools 0.130
ii udev 232-25+deb9u8
-- no debconf information
Michael Biebl
Feb 28, 2019, 2:00:04 PM2/28/19
to
Control: severity -1 wishlist
On Wed, 16 Jan 2019 12:44:28 -0600 "Karl O. Pinc" <k...@meme.com> wrote:
> Package: systemd
> Version: 232-25+deb9u8
> Severity: normal
>
> Hi,
>
> systemd security updates to stable
> systemd (232-25+deb9u8) stretch-security; urgency=high
> systemd (232-25+deb9u7) stretch-security; urgency=high
> required reboot to take effect, but /var/run/reboot-required
> was not `touch`ed. Therefore the unattended-upgrades
> package did not notify the user that a reboot is required.
> (There were related upgrades to udev and other packages.)
>
> There are probably many systems which installed the
> upgrade automatically but did not reboot and so the
> patch did not take effect.
>
> "The Internet" says that it is the postinst script which
> should touch /var/run/reboot-required.
>
This should probably be /run/reboot-required, /var/run is a symlink to /run.
That said, an update of the systemd package does not strictly require a
reboot of the system. We do reexec PID 1 and restart all binaries
(besides logind), so I'm a bit undecided if we should actually trigger
that message or not.
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
On Wed, 16 Jan 2019 12:44:28 -0600 "Karl O. Pinc" <k...@meme.com> wrote:
> Package: systemd
> Version: 232-25+deb9u8
> Severity: normal
>
> Hi,
>
> systemd security updates to stable
> systemd (232-25+deb9u8) stretch-security; urgency=high
> systemd (232-25+deb9u7) stretch-security; urgency=high
> required reboot to take effect, but /var/run/reboot-required
> was not `touch`ed. Therefore the unattended-upgrades
> package did not notify the user that a reboot is required.
> (There were related upgrades to udev and other packages.)
>
> There are probably many systems which installed the
> upgrade automatically but did not reboot and so the
> patch did not take effect.
>
> "The Internet" says that it is the postinst script which
> should touch /var/run/reboot-required.
>
That said, an update of the systemd package does not strictly require a
reboot of the system. We do reexec PID 1 and restart all binaries
(besides logind), so I'm a bit undecided if we should actually trigger
that message or not.
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
Karl O. Pinc
Feb 28, 2019, 4:30:02 PM2/28/19
to
On Thu, 28 Feb 2019 19:55:59 +0100
Michael Biebl <bi...@debian.org> wrote:
> On Wed, 16 Jan 2019 12:44:28 -0600 "Karl O. Pinc" <k...@meme.com>
> wrote:
> > systemd security updates to stable
> > systemd (232-25+deb9u8) stretch-security; urgency=high
> > systemd (232-25+deb9u7) stretch-security; urgency=high
> > required reboot to take effect, but /var/run/reboot-required
> > was not `touch`ed. Therefore the unattended-upgrades
> > package did not notify the user that a reboot is required.
> > (There were related upgrades to udev and other packages.)
> >
> > There are probably many systems which installed the
> > upgrade automatically but did not reboot and so the
> > patch did not take effect.
> >
> > "The Internet" says that it is the postinst script which
> > should touch /var/run/reboot-required.
> >
>
> This should probably be /run/reboot-required, /var/run is a symlink
> to /run.
Yes. See latest debian policy doc patch at:
Michael Biebl <bi...@debian.org> wrote:
> On Wed, 16 Jan 2019 12:44:28 -0600 "Karl O. Pinc" <k...@meme.com>
> wrote:
> > systemd security updates to stable
> > systemd (232-25+deb9u8) stretch-security; urgency=high
> > systemd (232-25+deb9u7) stretch-security; urgency=high
> > required reboot to take effect, but /var/run/reboot-required
> > was not `touch`ed. Therefore the unattended-upgrades
> > package did not notify the user that a reboot is required.
> > (There were related upgrades to udev and other packages.)
> >
> > There are probably many systems which installed the
> > upgrade automatically but did not reboot and so the
> > patch did not take effect.
> >
> > "The Internet" says that it is the postinst script which
> > should touch /var/run/reboot-required.
> >
>
> This should probably be /run/reboot-required, /var/run is a symlink
> to /run.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919507
> That said, an update of the systemd package does not strictly require
> a reboot of the system. We do reexec PID 1 and restart all binaries
> (besides logind), so I'm a bit undecided if we should actually trigger
> that message or not.
by package upgrade then the only reason to require a restart would
be if some changes in new systemd packages required a restart
of non-systemd components. So maybe this is a non-bug.
Regards,
Karl <k...@meme.com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
Michael Biebl
Mar 20, 2019, 11:00:04 AM3/20/19
to
Control: retitle -1 restart logind on package updates
Control: block -1 by 798097
On Thu, 28 Feb 2019 15:09:14 -0600 "Karl O. Pinc" <k...@meme.com> wrote:
> If systemd restarts all of its processes which are affected
> by package upgrade then the only reason to require a restart would
> be if some changes in new systemd packages required a restart
> of non-systemd components. So maybe this is a non-bug.
We restart (in buster) all systemd components besides logind:
https://salsa.debian.org/systemd-team/systemd/commit/b8c239e122ef193c6aab1c65ab1c6d2b598de3d7
logind nowadays supports being restarted
https://github.com/systemd/systemd/commit/aed24c4cd7641da6f530853d10637568c13c8f35
So the remaining bit is that Xorg no longer aborts on logind restarts
See
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798097
https://gitlab.freedesktop.org/xorg/xserver/issues/531
Once that is fixed in xserver-xorg, I would rather restart logind on
upgrades then requesting a reboot. So re-purposing the bug report
accordingly.
It's a bit sad that #798097 is still unfixed, but I'm not sure what I
can do to move this issue forward.
Regards,
Michael
Control: block -1 by 798097
On Thu, 28 Feb 2019 15:09:14 -0600 "Karl O. Pinc" <k...@meme.com> wrote:
> If systemd restarts all of its processes which are affected
> by package upgrade then the only reason to require a restart would
> be if some changes in new systemd packages required a restart
> of non-systemd components. So maybe this is a non-bug.
https://salsa.debian.org/systemd-team/systemd/commit/b8c239e122ef193c6aab1c65ab1c6d2b598de3d7
logind nowadays supports being restarted
https://github.com/systemd/systemd/commit/aed24c4cd7641da6f530853d10637568c13c8f35
So the remaining bit is that Xorg no longer aborts on logind restarts
See
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798097
https://gitlab.freedesktop.org/xorg/xserver/issues/531
Once that is fixed in xserver-xorg, I would rather restart logind on
upgrades then requesting a reboot. So re-purposing the bug report
accordingly.
It's a bit sad that #798097 is still unfixed, but I'm not sure what I
can do to move this issue forward.
Regards,
Michael
Michael Biebl
Nov 18, 2019, 10:10:03 PM11/18/19
to
This is blocked by a bug in gnome-shell which dies when logind is restarted:
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1881
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1881
Michael Biebl
Oct 12, 2022, 5:10:04 AM10/12/22
to
What remains are issues in both systemd and mutter:
https://github.com/systemd/systemd/issues/17308
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1556
0 new messages