Bug#828127: curl: FTBFS with openssl 1.1:

[Kurt Roeckx]

Source: curl
Version: 7.47.0-1
Severity: important
Control: block 827061 by -1

Hi,

Your package is failing to build with openssl 1.1:
vtls/openssl.c:758:3: warning: 'ERR_remove_thread_state' is deprecated [-Wdeprecated-declarations]
ERR_remove_thread_state(NULL);
^
In file included from /usr/include/openssl/ui.h:13:0,
from /usr/include/openssl/engine.h:29,
from ../lib/urldata.h:88,
from vtls/openssl.c:41:
/usr/include/openssl/err.h:244:1: note: declared here
DEPRECATEDIN_1_1_0(void ERR_remove_thread_state(void *))
^
vtls/openssl.c: In function 'get_cert_chain':
vtls/openssl.c:2389:20: error: dereferencing pointer to incomplete type 'EVP_PKEY {aka struct evp_pkey_st}'
switch(pubkey->type) {
^

From the manpage of ERR_remove_thread_state:
DESCRIPTION
The functions described here were used to free the error
queue associated with the current or specificed thread.

They are now deprecated and do nothing, as the OpenSSL
libraries now normally do all thread initialisation and
deinitialisation automatically (see OPENSSL_init_crypto(3)).


From the manpage of EVP_PKEY_base_id:
Most applications wishing to know a key type will simply
call EVP_PKEY_base_id() and will not care about the actual type:
which will be identical in almost all cases.

Previous versions of this document suggested using
EVP_PKEY_type(pkey->type) to determine the type of a key. Since
EVP_PKEY is now opaque this is no longer possible: the
equivalent is EVP_PKEY_base_id(pkey).


openssl 1.1.0 is available in experimental.

If you run into other problems you might want to look at:
https://wiki.openssl.org/index.php/1.1_API_Changes


Kurt

[Daniel Stenberg]

On Sat, 25 Jun 2016, Kurt Roeckx wrote:

The openssl 1.1 API has been evolving over time and it was not very long since
the most recent change. curl works fine with openssl 1.1 but only builds
warning-free with the current openssl master branch if you use curl from it's
master git branch.

The pending curl release (7.50.0) will work with the current openssl 1.1 API.
Until they change it again.

--

/ daniel.haxx.se