Bug#803329: pulseaudio: Bash completion files provided by wrong package

[Francois Gouget]

Package: pulseaudio
Version: 7.0-1
Severity: normal

Dear Maintainer,

The pulseaudio package provides bash completion files for pacat, pacmd, pactl, padsp,
paplay, parec, parecord and pasuspender but it does not provide the corresponding
binaries. These are in the pulseaudio-utils package so these completion files should be
in that package too.

/usr/share/bash-completion/completions/pacat
/usr/share/bash-completion/completions/pacmd
/usr/share/bash-completion/completions/pactl
/usr/share/bash-completion/completions/padsp
/usr/share/bash-completion/completions/paplay
/usr/share/bash-completion/completions/parec
/usr/share/bash-completion/completions/parecord
/usr/share/bash-completion/completions/pasuspender


-- Package-specific info:
File '/etc/default/pulseaudio' does not exist


-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages pulseaudio depends on:
ii adduser 3.113+nmu3
ii libasound2 1.0.29-1
ii libasound2-plugins 1:1.0.29-dmo1
ii libc6 2.19-22
ii libcap2 1:2.24-12
ii libdbus-1-3 1.10.0-3
ii libfftw3-single3 3.3.4-2
ii libgcc1 1:5.2.1-22
ii libice6 2:1.0.9-1+b1
ii libltdl7 2.4.2-1.11
ii liborc-0.4-0 1:0.4.24-1
ii libpulse0 7.0-1
ii libsm6 2:1.2.2-1+b1
ii libsndfile1 1.0.25-9.1
ii libspeexdsp1 1.2~rc1.2-1
ii libstdc++6 5.2.1-22
ii libsystemd0 227-2
ii libtdb1 1.3.7-1
ii libudev1 227-2
ii libwebrtc-audio-processing-0 0.1-3
ii libx11-6 2:1.6.3-1
ii libx11-xcb1 2:1.6.3-1
ii libxcb1 1.11.1-1
ii libxtst6 2:1.2.2-1+b1
ii lsb-base 9.20150917
ii pulseaudio-utils 7.0-1
ii udev 227-2

Versions of packages pulseaudio recommends:
ii pulseaudio-module-x11 7.0-1
ii rtkit 0.11-3

Versions of packages pulseaudio suggests:
pn paman <none>
pn paprefs <none>
pn pavucontrol <none>
pn pavumeter <none>

-- no debconf information

[Felipe Sateler]

Control: severity -1 minor

On 28 October 2015 at 17:15, Francois Gouget <fgo...@free.fr> wrote:
> Package: pulseaudio
> Version: 7.0-1
> Severity: normal
>
> Dear Maintainer,
>
> The pulseaudio package provides bash completion files for pacat, pacmd, pactl, padsp,
> paplay, parec, parecord and pasuspender but it does not provide the corresponding
> binaries. These are in the pulseaudio-utils package so these completion files should be
> in that package too.
>
> /usr/share/bash-completion/completions/pacat
> /usr/share/bash-completion/completions/pacmd
> /usr/share/bash-completion/completions/pactl
> /usr/share/bash-completion/completions/padsp
> /usr/share/bash-completion/completions/paplay
> /usr/share/bash-completion/completions/parec
> /usr/share/bash-completion/completions/parecord
> /usr/share/bash-completion/completions/pasuspender

What problem does this cause? Or what benefits does it cause to use
the correct package? I don't really want to complicate the packaging.

--

Saludos,
Felipe Sateler

[Francois Gouget]

It simply does not make sense to ship completion files for programs that
are shipped by another package. That alone should be sufficient reason.
After the pulseaudio package does not install the man pages for the
pulseaudio-utils programs.

Anyway, here's another reason: it's possible to install pulseaudio-utils
without installing pulseaudio. In this case the user will not have the
bash completion files for the pulseaudio-utils programs. And that's a
perfect illustration of the previous point.


--
Francois Gouget <fgo...@free.fr> http://fgouget.free.fr/
A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

[Kevin Locke]

On Fri, 2015-10-30 at 08:55 +0100, Francois Gouget wrote:
> On Wed, 28 Oct 2015, Felipe Sateler wrote:
>> What problem does this cause? Or what benefits does it cause to use
>> the correct package? I don't really want to complicate the packaging.
>

> Anyway, here's another reason: it's possible to install pulseaudio-utils
> without installing pulseaudio.

I just ran into this issue as you described. I have pulseaudio-utils
installed, but not pulseaudio (because I am using PipeWire as a
PulseAudio substitute[1]).

I sympathize with your desire to avoid complicating the packaging.
Splitting the completion file looks non-trivial. Might I suggest
shipping a copy of the completion file in the pulseaudio package as
/usr/share/bash-completion/completions/pulseaudio and a copy in the
pulseaudio-utils package as /usr/share/bash-completion/completions/pacmd
with symlinks for the other commands provided by that package? This way
a completion for each command is shipped in the same package. The 15kB
of duplicated data seems reasonable, if not ideal, to avoid divergence
from upstream, or the packaging work of creating a -common package just
for completions.

Thanks for considering,
Kevin

[1]: https://wiki.debian.org/PipeWire#Using_as_a_substitute_for_PulseAudio.2FJACK.2FALSA

[Felipe Sateler]

This is not really needed. pulseaudio already depends on pulseaudio-utils. I would accept a patch moving the completion files to the pulseaudio-utils package. 

--

Saludos,
Felipe Sateler

[Kevin Locke]

tags 803329 +patch
thanks

On Mon, 2021-03-08 at 09:56 -0300, Felipe Sateler wrote:
> I would accept a patch moving the completion files to the pulseaudio-utils
> package.

Great! Patch attached.

Cheers,
Kevin