Bug#1025959: RFS: davmail/6.0.1.3390-2 -- POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway

[Alexandre Rossi]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "davmail":

* Package name : davmail
Version : 6.0.1.3390-2
Upstream contact : Mickaël Guessant <mgue...@free.fr>
* URL : http://davmail.sourceforge.net/
* License : GPL-2+-CE, CC0-1.0, GPL-2+, MIT
* Vcs : https://salsa.debian.org/debian/davmail
Section : net

The source builds the following binary packages:

davmail - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - GUI
davmail-server - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - headless

To access further information about this package, please visit the following URL:

https://mentors.debian.net/package/davmail/

Alternatively, you can download the package with 'dget' using this command:

dget -x https://mentors.debian.net/debian/pool/main/d/davmail/davmail_6.0.1.3390-2.dsc

Changes since the last upload:

davmail (6.0.1.3390-2) unstable; urgency=medium
.
[ Gioele Barabucci ]
* d/postinst: Check systemd via /sbin/init
.
[ Alexandre Rossi ]
* Acknowledge 6.0.1.3390-1.1 NMU
* add sd-notify.patch
* update to policy 4.6.1.0 (no change)
* fix depends-on-essential-package-without-using-version
* update d/copyright year
* clarify depends: split davmail (GUI) and davmail-server (Closes: #1018809)

Regards,
--
Alexandre Rossi

[Geert Stappers]

On Mon, Dec 12, 2022 at 03:29:08PM +0100, Alexandre Rossi wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "davmail":

:-)

> * Package name : davmail
> Version : 6.0.1.3390-2

> Upstream contact : Mickaėl Guessant <mgue...@free.fr>

> * URL : http://davmail.sourceforge.net/
> * License : GPL-2+-CE, CC0-1.0, GPL-2+, MIT
> * Vcs : https://salsa.debian.org/debian/davmail
> Section : net
>
> The source builds the following binary packages:
>
> davmail - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - GUI
> davmail-server - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - headless

The -server package is probably new.

> To access further information about this package, please visit the following URL:
>
> https://mentors.debian.net/package/davmail/
>
> Alternatively, you can download the package with 'dget' using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/d/davmail/davmail_6.0.1.3390-2.dsc

I will check it tuesday 2022-12-13 CET.

> Changes since the last upload:
>
> davmail (6.0.1.3390-2) unstable; urgency=medium
> .
> [ Gioele Barabucci ]
> * d/postinst: Check systemd via /sbin/init
> .
> [ Alexandre Rossi ]
> * Acknowledge 6.0.1.3390-1.1 NMU
> * add sd-notify.patch
> * update to policy 4.6.1.0 (no change)
> * fix depends-on-essential-package-without-using-version
> * update d/copyright year
> * clarify depends: split davmail (GUI) and davmail-server (Closes: #1018809)
>
> Regards,

> Alexandre Rossi


Groeten
Geert Stappers

P.S.

What about D.M. upload privileges?
--
Silence is hard to parse

[Alexandre Rossi]

Hi,

> > The source builds the following binary packages:
> >
> > davmail - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - GUI
> > davmail-server - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - headless
>
> The -server package is probably new.

That's why I need a sponsor.

> What about D.M. upload privileges?

I have those, but because the -server package goes through NEW, it does not apply.

Cheers and thanks,

Alexandre

[Geert Stappers]

On Mon, Dec 12, 2022 at 05:14:23PM +0100, Alexandre Rossi wrote:
> Hi,
>
> > > The source builds the following binary packages:
> > >
> > > davmail - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - GUI
> > > davmail-server - POP/IMAP/SMTP/CalDav/LDAP to Microsoft Exchange gateway - headless
> >
> > The -server package is probably new.
>
> That's why I need a sponsor.

Working on it :-)

> > What about D.M. upload privileges?
>
> I have those, but because the -server package goes through NEW, it does not apply.
>
> Cheers and thanks,

Feedback:

* The packaging git repo is not up to date
* Systemd unit file `debian/davmail.service` is not installed
in davmail-server (Neither in davmail)
* Script `debian/prepare-service` feels wrong
if keystore is a file
then copy+chown keystore
else remove keystore
That doesn't make sense


Request:

* Add the release "davmail (6.0.1.3390-1.1)" to packaging git repo
* Review / improve the `prepare-service`
* Make that `davmail-service` makes it into `davmail-server` package
* Ping me


> Alexandre


Groeten
Geert Stappers

[Alexandre Rossi]

Hi,

> * Add the release "davmail (6.0.1.3390-1.1)" to packaging git repo

Pushed.
Further changes are awaiting upload to unstable before being pushed.

> * Review / improve the `prepare-service`

This history behind this script is detailed in:

startup script that copies keystoreFile to StateDirectory (Closes: #968236)
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968236

The point is to make available private keys to the daemon. Do you think I need
to add comments to the script to explain the purpose?

> * Make that `davmail-service` makes it into `davmail-server` package

Fixed, thanks and sorry for that.

> * Ping me

New source package is on mentors.

Alexandre

[Geert Stappers]

On Wed, Dec 14, 2022 at 10:14:09AM +0100, Alexandre Rossi wrote:
> Hi,
>
> > * Add the release "davmail (6.0.1.3390-1.1)" to packaging git repo
>
> Pushed.

Ack

> Further changes are awaiting upload to unstable before being pushed.

See below

> > * Review / improve the `prepare-service`
>
> This history behind this script is detailed in:
>
> startup script that copies keystoreFile to StateDirectory (Closes: #968236)
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968236

Seen the "adduser _davmail" advice.
And seeing that "adduser _davmail" in debian/davmail-server.postinst
(I didn't see that post install script yesterday)

> The point is to make available private keys to the daemon. Do you think I need
> to add comments to the script to explain the purpose?

Yes please, elaborate purpose AND elaborate the

if keystore is a file then create keystore file

> > * Make that `davmail-service` makes it into `davmail-server` package
>
> Fixed, thanks and sorry for that.

Thanks for fixing and thanks for confirming the "good catch".

> > * Ping me
>
> New source package is on mentors.

What about doing this development in a git branch?

Your benefit: No need for a `dput` to mentors, just `git push` the
branch.

My benefit: No need to visit mentors for URL that I can `dget`,
just `git pull`.

Another benefit for you: No duplicates in reporting progress.
Report to "git" by commit message.

Tell me the branch name to use.
Telling me there won't be such development branch is fine, we use mentors.


> Alexandre

Groeten
Geert Stappers
Fully aware that the freeze before the Bookworm release is nearby

[Alexandre Rossi]

Hi,

> > > * Review / improve the `prepare-service`
> >
> > This history behind this script is detailed in:
> >
> > startup script that copies keystoreFile to StateDirectory (Closes: #968236)
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968236
>
> Seen the "adduser _davmail" advice.
> And seeing that "adduser _davmail" in debian/davmail-server.postinst
> (I didn't see that post install script yesterday)
>
> > The point is to make available private keys to the daemon. Do you think I need
> > to add comments to the script to explain the purpose?
>
> Yes please, elaborate purpose AND elaborate the
>
> if keystore is a file then create keystore file

https://salsa.debian.org/debian/davmail/-/commit/be580785dbd6a4232a2fe408c144ccfc80f93017

> What about doing this development in a git branch?

https://salsa.debian.org/debian/davmail/-/tree/unstable-wip

Many thanks for your review,

Alexandre