Bug#1025825: ImportError: cannot import name 'safe_join' from 'flask'

[Rock Storm]

Package: grip
Version: 4.2.0-3
Severity: important
X-Debbugs-Cc: rock...@gmx.com

Dear Maintainer,

Program will not even start with the following trace:

```
$ grip -b
Traceback (most recent call last):
File "/usr/bin/grip", line 9, in <module>
load_entry_point('grip==4.2.0', 'console_scripts', 'grip')()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 486, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2867, in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2471, in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2477, in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
File "/usr/share/grip/grip/__init__.py", line 13, in <module>
from .api import (
File "/usr/share/grip/grip/api.py", line 8, in <module>
from .app import Grip
File "/usr/share/grip/grip/app.py", line 28, in <module>
from .assets import GitHubAssetManager, ReadmeAssetManager
File "/usr/share/grip/grip/assets.py", line 16, in <module>
from flask import safe_join
ImportError: cannot import name 'safe_join' from 'flask' (/usr/lib/python3/dist-packages/flask/__init__.py)
```

Please let me know if I can help to debug any further.


-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.19.0-1-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages grip depends on:
ii python3 3.10.6-1
ii python3-docopt 0.6.2-4
ii python3-flask 2.2.2-2
ii python3-markdown 3.4.1-2
ii python3-path-and-address 2.0.1-3
ii python3-pygments 2.13.0+dfsg-1
ii python3-requests 2.27.1+dfsg-1

grip recommends no packages.

grip suggests no packages.

-- no debconf information

[Renzo Davoli]

The following patch should fix the problem.
renzo

----
diff -Naur grip-4.2.0/debian/control grip-4.2.0.fixed/debian/control
--- grip-4.2.0/debian/control 2016-07-03 23:21:52.000000000 +0200
+++ grip-4.2.0.fixed/debian/control 2023-09-13 15:20:13.527645376 +0200
@@ -12,6 +12,7 @@
python3-requests,
python3-responses (>= 0.5.0),
python3-setuptools
+ python3-werkzeug
Build-Depends-Indep: txt2man
Standards-Version: 3.9.8
Testsuite: autopkgtest
diff -Naur grip-4.2.0/grip/assets.py grip-4.2.0.fixed/grip/assets.py
--- grip-4.2.0/grip/assets.py 2016-04-16 17:51:39.000000000 +0200
+++ grip-4.2.0.fixed/grip/assets.py 2023-09-13 15:20:59.344112922 +0200
@@ -13,7 +13,7 @@
from urllib.parse import urljoin

import requests
-from flask import safe_join
+from werkzeug.utils import safe_join

from .constants import (
STYLE_URLS_SOURCE, STYLE_URLS_RE, STYLE_ASSET_URLS_RE,
diff -Naur grip-4.2.0/grip/readers.py grip-4.2.0.fixed/grip/readers.py
--- grip-4.2.0/grip/readers.py 2016-04-16 17:51:39.000000000 +0200
+++ grip-4.2.0.fixed/grip/readers.py 2023-09-13 15:21:13.596250094 +0200
@@ -8,7 +8,7 @@
import sys
from abc import ABCMeta, abstractmethod

-from flask import safe_join
+from werkzeug.utils import safe_join

from .constants import DEFAULT_FILENAMES, DEFAULT_FILENAME
from .exceptions import ReadmeNotFoundError

[Stanislav Maslovski]

Package: grip
Version: 4.2.0-3
Followup-For: Bug #1025825
X-Debbugs-Cc: stanislav...@gmail.com

Hi,

The changelog to v. 2.1.0 of flask says:

"safe_join is removed, use werkzeug.utils.safe_join instead."

So, either a patch or an update is needed for grip package.

As a workaround, downgrading python3-flask to v. 2.0.3-1 (available at
snapshot.debian.org) may help.

BR,

Stanislav