Bug#955620: cloud-init - debian/rules clean fails from git repo

[Bastian Blank]

Package: cloud-init
Version: 20.1-X
Severity: important

Currently running debian/rules clean from git repository fails:

| % ./debian/rules clean
| py3versions: no X-Python3-Version in control file, using supported versions
| dh clean --with python3,systemd --buildsystem pybuild
| dh_auto_clean -O--buildsystem=pybuild
| I: pybuild base:217: python3.7 setup.py clean
| Traceback (most recent call last):
| File "setup.py", line 293, in <module>
| version=get_version(),
| File "setup.py", line 85, in get_version
| (ver, _e) = tiny_p(cmd)
| File "setup.py", line 50, in tiny_p
| (cmd, ret, out, err))
| RuntimeError: Failed running ['/usr/bin/python3.7', 'tools/read-version'] [rc=1] (, git describe version (0.7.9-145-g12042ee9) differs from cloudinit.version (20.1)
| Please get the latest upstream tags.
| As an example, this can be done with the following:
| $ git remote add upstream https://git.launchpad.net/cloud-init
| $ git fetch upstream --tags
| )
| E: pybuild pybuild:352: clean: plugin distutils failed with: exit code=1: python3.7 setup.py clean
| dh_auto_clean: error: pybuild --clean --test-nose -i python{version} -p "3.7 3.8" returned exit code 13
| make: *** [debian/rules:7: clean] Error 13

Bastian

-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cloud-init depends on:
ii fdisk 2.34-0.1
ii gdisk 1.0.5-1
pn ifupdown <none>
ii locales 2.30-2
ii lsb-base 11.1.0
ii lsb-release 11.1.0
ii net-tools 1.60+git20180626.aebd88e-1
ii procps 2:3.3.16-4
ii python3 3.8.2-2
pn python3-configobj <none>
ii python3-jinja2 2.10.1-2
pn python3-jsonpatch <none>
pn python3-jsonschema <none>
pn python3-oauthlib <none>
ii python3-requests 2.22.0-2
ii python3-six 1.14.0-2
ii python3-yaml 5.3.1-1
ii util-linux 2.34-0.1

Versions of packages cloud-init recommends:
pn cloud-guest-utils <none>
pn eatmydata <none>
ii sudo 1.8.31p1-1

Versions of packages cloud-init suggests:
pn btrfs-progs <none>
ii e2fsprogs 1.45.6-1
pn xfsprogs <none>

[Noah Meyerhans]

On Fri, Apr 03, 2020 at 03:54:34PM +0200, Bastian Blank wrote:
> Currently running debian/rules clean from git repository fails:
>
> | % ./debian/rules clean
> | py3versions: no X-Python3-Version in control file, using supported versions
> | dh clean --with python3,systemd --buildsystem pybuild
> | dh_auto_clean -O--buildsystem=pybuild
> | I: pybuild base:217: python3.7 setup.py clean
> | Traceback (most recent call last):
> | File "setup.py", line 293, in <module>
> | version=get_version(),
> | File "setup.py", line 85, in get_version
> | (ver, _e) = tiny_p(cmd)
> | File "setup.py", line 50, in tiny_p
> | (cmd, ret, out, err))
> | RuntimeError: Failed running ['/usr/bin/python3.7', 'tools/read-version'] [rc=1] (, git describe version (0.7.9-145-g12042ee9) differs from cloudinit.version (20.1)
> | Please get the latest upstream tags.
> | As an example, this can be done with the following:
> | $ git remote add upstream https://git.launchpad.net/cloud-init
> | $ git fetch upstream --tags
> | )
> | E: pybuild pybuild:352: clean: plugin distutils failed with: exit code=1: python3.7 setup.py clean
> | dh_auto_clean: error: pybuild --clean --test-nose -i python{version} -p "3.7 3.8" returned exit code 13
> | make: *** [debian/rules:7: clean] Error 13

This is only the case if the debian patches aren't applied; we apply
debian/patches/0009-Drop-all-unused-extended-version-handling.patch to
remove all the git parsing from the tools/read-version command. So I'm
not sure this is actually a bug. Is there anywhere that we actually
depend on the ability to run 'debian/rules clean' on an unpatched source
tree?

As an alternative, we could defer to the upstream Makefile's 'clean'
target and skip the pybuild clean process.

noah

[Noah Meyerhans]

Control: tags -1 + patch

Proposed fix is at https://salsa.debian.org/cloud-team/cloud-init/-/merge_requests/9