Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#1006348: lintian: Tag improbable-bug-number-in-closes condition considers 7-digit bug numbers improbable
55 views
Skip to first unread message
Ben Finney
Feb 23, 2022, 6:50:04 PM2/23/22
to
Package: lintian
Version: 2.111.0
Severity: normal
Tags: patch
The Debian bug tracker is well into 7-digit bug numbers now, so the
‘improbable-bug-number-in-closes’ condition should permit them.
Currently the tag's condition matches all bug numbers 1000000 or
higher:
=====
W: xkcdpass: improbable-bug-number-in-closes 1006311
=====
The maximum bug number should be increased to allow likely bug numbers
for some number of years into the future.
I propose this change:
-----
modified data/changelog-file/bugs-number
@@ -1,4 +1,4 @@
-# before 50004 but were removed not archived
+# Before 50004, bugs were removed not archived.
min-bug = 50004
-# a bug number likely for in future
-max-bug = 1000000
\ No newline at end of file
+# A bug number likely far in the future.
+max-bug = 2000000
-----
--
\ “Kill myself? Killing myself is the last thing I'd ever do.” |
`\ —Homer, _The Simpsons_ |
_o__) |
Ben Finney <big...@debian.org>
Version: 2.111.0
Severity: normal
Tags: patch
The Debian bug tracker is well into 7-digit bug numbers now, so the
‘improbable-bug-number-in-closes’ condition should permit them.
Currently the tag's condition matches all bug numbers 1000000 or
higher:
=====
W: xkcdpass: improbable-bug-number-in-closes 1006311
=====
The maximum bug number should be increased to allow likely bug numbers
for some number of years into the future.
I propose this change:
-----
modified data/changelog-file/bugs-number
@@ -1,4 +1,4 @@
-# before 50004 but were removed not archived
+# Before 50004, bugs were removed not archived.
min-bug = 50004
-# a bug number likely for in future
-max-bug = 1000000
\ No newline at end of file
+# A bug number likely far in the future.
+max-bug = 2000000
-----
--
\ “Kill myself? Killing myself is the last thing I'd ever do.” |
`\ —Homer, _The Simpsons_ |
_o__) |
Ben Finney <big...@debian.org>
Ben Finney
Feb 23, 2022, 7:00:04 PM2/23/22
to
On 24-Feb-2022, Ben Finney wrote:
> Currently the tag's condition matches all bug numbers 1000000 or
> higher:
>
> =====
> W: xkcdpass: improbable-bug-number-in-closes 1006311
> =====
>
> The maximum bug number should be increased to allow likely bug numbers
> for some number of years into the future.
I'm not clear on why this occurs. The relevant code appears to be in
> Currently the tag's condition matches all bug numbers 1000000 or
> higher:
>
> =====
> W: xkcdpass: improbable-bug-number-in-closes 1006311
> =====
>
> The maximum bug number should be increased to allow likely bug numbers
> for some number of years into the future.
‘lib/Lintian/Check/Debian/Changelog.pm’:
=====
for my $bug (@{$latest_entry->Closes}) {
$self->pointed_hint('improbable-bug-number-in-closes',
$latest_pointer, $bug)
if $bug < $FIRST_ARCHIVED_BUG_NUMBER
|| $bug >= $OUT_OF_REACH_BUG_NUMBER;
}
=====
where ‘$OUT_OF_REACH_BUG_NUMBER’ is defined in the same file:
=====
const my $OUT_OF_REACH_BUG_NUMBER => 1_500_000;
=====
Yet, with Lintian version 2.111.0, I get the tag raised for bug
numbers lower than that.
=====
$ lintian --version
Lintian v2.111.0
$ lintian
[…]
W: xkcdpass: improbable-bug-number-in-closes 1006311
=====
--
=====
\ “Pity the meek, for they shall inherit the earth.” —Donald |
`\ Robert Perry Marquis |
_o__) |
Ben Finney <big...@debian.org>
Felix Lechner
Feb 23, 2022, 7:10:03 PM2/23/22
to
Hi,
On Wed, Feb 23, 2022 at 3:57 PM Ben Finney <big...@debian.org> wrote:
>
> const my $OUT_OF_REACH_BUG_NUMBER => 1_500_000;
Due to a new override format, which remained pending due to my
extremely critical commitment elsewhere, the change remains
unreleased.
I hope to get to Bug#1003272 tomorrow or on Friday, with a release
soon after that.
Kind regards
Felix Lechner
On Wed, Feb 23, 2022 at 3:57 PM Ben Finney <big...@debian.org> wrote:
>
> const my $OUT_OF_REACH_BUG_NUMBER => 1_500_000;
extremely critical commitment elsewhere, the change remains
unreleased.
I hope to get to Bug#1003272 tomorrow or on Friday, with a release
soon after that.
Kind regards
Felix Lechner
Ben Finney
Feb 23, 2022, 7:30:04 PM2/23/22
to
Control: block -1 by 1003272
Control: tags -1 + confirmed pending
On 23-Feb-2022, Felix Lechner wrote:
> Due to a new override format, which remained pending due to my
> extremely critical commitment elsewhere, the change remains
> unreleased.
>
> I hope to get to Bug#1003272 tomorrow or on Friday, with a release
> soon after that.
Thank you. I'm now recording that in the metadata for this bug report.
--
\ “If you are unable to leave your room, expose yourself in the |
`\ window.” —instructions in case of fire, hotel, Finland |
_o__) |
Ben Finney <big...@debian.org>
Control: tags -1 + confirmed pending
On 23-Feb-2022, Felix Lechner wrote:
> Due to a new override format, which remained pending due to my
> extremely critical commitment elsewhere, the change remains
> unreleased.
>
> I hope to get to Bug#1003272 tomorrow or on Friday, with a release
> soon after that.
--
\ “If you are unable to leave your room, expose yourself in the |
`\ window.” —instructions in case of fire, hotel, Finland |
_o__) |
Ben Finney <big...@debian.org>
0 new messages