Bug#995274: needrestart: false positive: rabbitmq-server

Antonio Terceiro

unread,

Sep 28, 2021, 7:40:03 PM9/28/21

to

Package: needrestart
Version: 3.5-4
Severity: normal

Dear Maintainer,

Recently every time I install something, needrestart seems to think that
rabbitmq-server needs to be restart, even when there were norelated
upgrades. I tried calling needrestart right after booting, and even then
it reported rabbitmq-server as needing a restart.

This can easily be reproduced in a clean testin VM:

----------------8<----------------8<----------------8<-----------------
root@host:~# apt update -q=2
20 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@host:~# apt install -q=2 -y needrestart
[...]
root@host:~# apt install -q=2 -y rabbitmq-server
[...]
Package configuration

┌────┤ Daemons using outdated libraries ├─────┐
│ │
│ │
│ Which services should be restarted? │
│ │
│ [*] rabbitmq-server.service │
│ │
│ │
│ <Ok> <Cancel> │
│ │
└─────────────────────────────────────────────┘

systemctl restart rabbitmq-server.service

No containers need to be restarted.

No user sessions are running outdated binaries.
----------------8<----------------8<----------------8<-----------------

-- System Information:
Debian Release: bookworm/sid
APT prefers testing-debug
APT policy: (900, 'testing-debug'), (900, 'testing'), (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.14.0-1-amd64 (SMP w/4 CPU threads)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), LANGUAGE=pt_BR:pt:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages needrestart depends on:
ii binutils 2.37-7
ii dpkg 1.20.9
ii gettext-base 0.21-4
ii libintl-perl 1.26-3
ii libmodule-find-perl 0.15-1
ii libmodule-scandeps-perl 1.31-1
ii libproc-processtable-perl 0.611-1
ii libsort-naturally-perl 1.03-2
ii libterm-readkey-perl 2.38-1+b2
ii perl 5.32.1-6
ii xz-utils 5.2.5-2

Versions of packages needrestart recommends:
ii libpam-systemd 247.9-1

Versions of packages needrestart suggests:
ii iucode-tool 2.3.1-1
ii libnotify-bin 0.7.9-3

-- no debconf information

signature.asc

Thomas Liske

unread,

Oct 10, 2021, 5:00:03 PM10/10/21

to

Hi,

could you please provide the output of `needrestart -lv`?

TIA,
Thomas

Antonio Terceiro

unread,

Oct 10, 2021, 6:30:04 PM10/10/21

to

On Sun, Oct 10, 2021 at 10:51:13PM +0200, Thomas Liske wrote:
> Hi,
>
> could you please provide the output of `needrestart -lv`?

Sure:

----------------8<----------------8<----------------8<-----------------
$ sudo needrestart -lv
[main] eval /etc/needrestart/needrestart.conf
[main] needrestart v3.5
[main] running in root mode
[Core] Using UI 'NeedRestart::UI::stdio'...
[main] systemd detected
[main] #968 uses deleted /memfd:vmem
[main] #968 is not a child
[Core] #2617 is a NeedRestart::Interp::Python
[Python] #2617: source=/home/terceiro/src/localslackirc/irc.py
[Core] #65382 is a NeedRestart::Interp::Python
[Python] #65382: source=/usr/bin/terminator
[Core] #90184 is a NeedRestart::Interp::Python
[Python] #90184: source=/usr/lib/python3/dist-packages/gbp/scripts/supercommand.py
[Core] #90219 is a NeedRestart::Interp::Perl
[Perl] #90219: source=/usr/bin/dpkg-buildpackage
[Core] #90247 is a NeedRestart::Interp::Perl
[Perl] #90247: source=/usr/bin/dh
[Core] #90274 is a NeedRestart::Interp::Python
[Python] #90274: source=/home/terceiro/src/debian/python/build-area/typeshed-0.0~git20211009.0142ea8.obsolete.1633904505.3296812/debian/install_stubs.py
[Core] #92031 is a NeedRestart::Interp::Python
[Python] #92031: source file not found, skipping
[Python] #92031: reduced ARGV: install --system --target=debian/python3-typeshed/usr/lib/python3/dist-packages /tmp/tmpwowqtmgb/dist/types_httplib2-0.19.1-py3-none-any.whl
[main] #968 exe => /usr/lib/erlang/erts-12.0.4/bin/beam.smp
[main] trying systemctl status
[main] #968 is rabbitmq-server.service

Restarting services...
Services to be restarted:
Restart «rabbitmq-server.service»? [Ynas?] n
Service restarts being deferred:

signature.asc

Thomas Liske

unread,

Oct 11, 2021, 1:30:02 AM10/11/21

to

tags 995274 upstream fixed-upstream
thanks

Hi,

thanks for the verbose output. This is due to anonymous file mapping
/memfd (see also #988461). Has been already fixed upstream in
needrestart 3.6+ [1].

[1]
https://github.com/liske/needrestart/commit/6c87772bdc38091e9efbf4c59217fa502365dcf2#diff-5e347a5df78db1304c1f2f21e27bb9122a186cf9c772a32ccaa23b424aac21a3

Regards,
Thomas

On Sun, 2021-10-10 at 19:25 -0300, Antonio Terceiro wrote:
> [main] eval /etc/needrestart/needrestart.conf