Bug#1019501: ansible-mitogen should probably depend on ansible and not on ansible-core

[Florian Küpper]

Package: ansible-mitogen
Version: 0.3.3-2

Dear python packaging Team,
in docs/ansible_detailed.rst#noteworthy-differences it is layed out
that for newer ansible versions,
which split ansible-core and ansible , ansible 5 is satisfying
mitogens (ansible) depedencies.
Next upstream iteration ansible 6 will be supported.

Your control file however has a nearly explicit dependency on debians
current ansible-core.
For bookworm that amounts to a "de-facto inverse dependency" of
ansible-core on ansible-mitogen.

I beleive I saw autopkg-tests and I wonder if You could relax Your
control file to reflect that and instead fail only if tests fail.

Many Thanks in advance!
Florian

[Stefano Rivera]

Hi Florian (2022.09.10_15:53:28_+0000)

> Dear python packaging Team,
> in docs/ansible_detailed.rst#noteworthy-differences it is layed out
> that for newer ansible versions,
> which split ansible-core and ansible , ansible 5 is satisfying
> mitogens (ansible) depedencies.
> Next upstream iteration ansible 6 will be supported.

Sorry, I've read this bug several times, and I'm really struggling to
understand it.

I don't know what in the Noteworthy Differences section of the file
you're referring to, but I can't find anything that seems relevant.

> Your control file however has a nearly explicit dependency on debians
> current ansible-core.
> For bookworm that amounts to a "de-facto inverse dependency" of
> ansible-core on ansible-mitogen.

I have no idea what this means. Examples would help.

Can you please explain what behaviour you are expecting that you aren't
getting? Or how this dependency is causing a problem for you?

ansible-mitogen only needs ansible-core, not ansible. However for
friendliness to backports etc. I allow either ansible-core or ansible to
satisfy the dependency.

These days, ansible Depends on ansible-core.

> I beleive I saw autopkg-tests and I wonder if You could relax Your
> control file to reflect that and instead fail only if tests fail.

Again, I don't understand what is being proposed here, sorry. How about
a patch?

SR

--
Stefano Rivera
http://tumbleweed.org.za/
+1 415 683 3272

[Florian Küpper]

Dear Stefano,
I am really sorry that I confused You and I must have overthought
while looking at the code and failed to adequately
express myself.
Of course You are right to ask for a patch and I have to confess that
what is holding me back is the lack of understanding of gbp and the
fact that I don't actively use mitogen.
(With some directions I would try though.)
First the problem and the solution with the least effort:

Looking at https://tracker.debian.org/pkg/python-mitogen
under actions it says: "unsatisfied dependency on ansible-core (< 2.13) "

Now ansible-core 2.13.3-1 has a regression:
https://tracker.debian.org/pkg/ansible-core
"... makes ansible-mitogen/0.3.3-2/amd64 uninstallable".

Easy solution: I assume allowing to run against that will work fine.

https://salsa.debian.org/python-team/packages/python-mitogen/-/blob/debian/master/debian/control#L41
ansible-core (<< 2.14)

And if I am wrong in this point, all further thoughts in my initial
report go to the trash can.
So I am willing as a first step , to test that assumtion.

However after:
apt build-dep python-mitogen
gbp clone https://salsa.debian.org/python-team/packages/python-mitogen.git
gbp buildpackage

I faill at one ssh test:
======================================================================
FAIL: test_debug_decoding (ssh_test.SshTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/mitogen-tests/build_area/python-mitogen-0.3.3/tests/ssh_test.py",
line 57, in test_debug_decoding
self.assertTrue(expect in s)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 661 tests in 36.886s

FAILED (failures=1, skipped=53)


The result is the same, whether I have ansible-core form bookworm or
sid installed.
(.. and also this is before I had a chance to edit something in the package)

So I would like to sum up:
How to make ansible-mitogen run with ansible-core/unstable ?
If You like, You can try or
I can , as a homework try to reproduce if apt-get -b source
python-mitogen fails on a current clean bookworm vm and we can work it
from there.

I hope this is better and I am willing to do my part.
So tell me anything I can do (asciicast / jitsi-meeting / test vm ) to
progress the matter.

Thanks, Florian

[stef...@debian.org]

control: retitle -1 Support ansible 6 (2.13)

Hi Florian (2022.09.11_20:09:21_+0000)

> Looking at https://tracker.debian.org/pkg/python-mitogen
> under actions it says: "unsatisfied dependency on ansible-core (< 2.13) "
>
> Now ansible-core 2.13.3-1 has a regression:
> https://tracker.debian.org/pkg/ansible-core
> "... makes ansible-mitogen/0.3.3-2/amd64 uninstallable".

Aha, yes, that is just the problem.

That restriction on 2.13 came from upstream. We include it as a package
Depends, so that users know early that it won't work.

Mitogen itself checks the version of ansible and fails if it's too new.

We're going to need https://github.com/mitogen-hq/mitogen/pull/933 (and
possibly other patches)

[Florian Küpper]

AH , now I can see the restriction:
https://github.com/mitogen-hq/mitogen/blob/master/ansible_mitogen/loaders.py#L52
Then it is the correct of the package to enforce that as well.
I still hope upstream comes to the conclusion, that this is wrong and
goes this way:
https://github.com/mitogen-hq/mitogen/issues/961

And You say while the burden of providing ansbile-mitogen is still on
the pyhon packaging team You would patch up 0.3.3 with
https://github.com/mitogen-hq/mitogen/pull/933 ?

Should I also try ? What are the next steps ?