Bug#1001361: software-properties-gtk: the "other" field under "download from" does not respond

[Debby]

Package: software-properties-gtk
Version: 0.96.20.2-2.1
Severity: important

Dear Maintainer,

* What led up to the situation?

Attempting to change download location using the "other" option in the
"download from" drop-down menu. This was attempted by opening software-
properties-gtk in a terminal and, alternatively, using Synaptic:
Settings>Repositories.

* What was the outcome of this action?

Terminal output is the following:

1) When opening software-properties-gtk:

ERROR:root:Cannot import UbuntuDrivers: No module named 'UbuntuDrivers'

(software-properties-gtk:): Gtk-WARNING **: : Could not load a pixbuf from
/org/gtk/libgtk/theme/Adwaita/assets/check-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

2) When selecting "other" option in the "download from" drop-down menu:

Traceback (most recent call last):
File "/usr/lib/python3/dist-
packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 553, in
on_combobox_server_changed
dialog = DialogMirror(self.window_main,
File "/usr/lib/python3/dist-packages/softwareproperties/gtk/DialogMirror.py",
line 83, in __init__
self.country_info = CountryInformation()
File "/usr/lib/python3/dist-
packages/softwareproperties/CountryInformation.py", line 34, in __init__
it = et.getiterator('iso_3166_entry')
AttributeError: 'ElementTree' object has no attribute 'getiterator'


* What outcome did you expect instead?

When selecting "other" under the "download from" drop-down menu, software-
properties-gtk should open a pop-up menu displaying download locations
available.




-- System Information:
Debian Release: 11.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500,
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-9-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages software-properties-gtk depends on:
ii gir1.2-gtk-3.0 3.24.24-4
ii python3 3.9.2-3
ii python3-gi 3.38.0-2
ii python3-software-properties 0.96.20.2-2.1
ii software-properties-common 0.96.20.2-2.1

software-properties-gtk recommends no packages.

Versions of packages software-properties-gtk suggests:
pn gnome-software <none>

[Zunda Taro]

Package: python3-software-properties
Version: 0.96.20.2-2.1
Followup-For: Bug #1001361
X-Debbugs-Cc: ecnd...@gmail.com

Dear Maintainer,

I suggest the bug fix of the file `CountryInformation.py` included in the package.

* What led up to the situation?

The same as what Debby reported, selecting "Other..." of "Download from" in `software-properties-gtk`
silently fails and the log shows Python Error.

* What exactly did you do (or not do) that was effective (or
ineffective)?

1. Ran `software-properties-gtk`
2. In "Debian Software" tab, tried to change "Download from" option to "Other..."

* What was the outcome of this action?

Nothing would happen on the GUI while the terminal showed python error log same as Debby quoted.

* What outcome did you expect instead?

It should show the dialog of the servers list so that users can choose the faster mirror.

* My solution

This bug can simply be fixed by changing a method call in `CountryInformation.py`, line 34 as:

< it = et.getiterator('iso_3166_entry')

---
> it = et.iter('iso_3166_entry')

Please check this solution and consider merging this bug fix for the next version.

Thank you in advance and best regards,
Taro.

-- System Information:
Debian Release: 11.4

APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-17-amd64 (SMP w/8 CPU threads)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), LANGUAGE not set

Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages python3-software-properties depends on:
ii iso-codes 4.6.0-1
ii lsb-release 11.1.0
ii python3 3.9.2-3
ii python3-apt 2.2.1
ii python3-pycurl 7.43.0.6-5

Versions of packages python3-software-properties recommends:
ii unattended-upgrades 2.8

python3-software-properties suggests no packages.

-- debconf-show failed