Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Bug#1003976: RFS: xmrig/6.16.2-1 [ITP] -- High performance, open source CPU/GPU miner and RandomX benchmark.
1 view
Skip to first unread message
Ben Westover
Apr 15, 2023, 12:50:05 PM4/15/23
to
Hi Bastian,
> If you submit the package for package maintenance in the Cryptocoin
> Team, I would be inclined to take a look.
That sounds great! I wish I would've known of that team this whole time.
I've listed team+cr...@tracker.debian.org as the maintainer in my
d/control file, and requested access to the Salsa group.
Thanks,
--
Ben Westover
> If you submit the package for package maintenance in the Cryptocoin
> Team, I would be inclined to take a look.
That sounds great! I wish I would've known of that team this whole time.
I've listed team+cr...@tracker.debian.org as the maintainer in my
d/control file, and requested access to the Salsa group.
Thanks,
--
Ben Westover
Ben Westover
Apr 17, 2023, 6:12:30 PM4/17/23
to
Hello,
On 4/17/23 2:13 PM, Bastian Germann wrote:
> Please see
> https://salsa.debian.org/cryptocoin-team/xmrig/-/commit/fa8aaf366f7168be3d30ba9c1d7e5fdaf9bb11bb to get an idea of what is to exclude. Please use the Debian replacements for those libraries. adl and libethash are not yet available (see also #1034528), so please build with WITH_KAWPOW=OFF and WITH_ADL=OFF.
I looked into this when I first started packaging xmrig. Unfortunately,
for many of these third party libraries, Debian's packaging of them
won't work because the version included in xmrig is specially modified
and contains lots of xmrig-specific functions that aren't easy to work
around. For example, many of argon2's functions directly have xmrig in
the name, and work a bit differently to those of the original project.
The source also directly includes headers that exist in the original
source but not a packaged version, and which are also modified
specifically for xmrig. If I were to get rid of all the third party
libraries that don't work easily with Debian's packaged versions, there
wouldn't be much xmrig functionality left.
Thanks,
--
Ben Westover
On 4/17/23 2:13 PM, Bastian Germann wrote:
> Please see
> https://salsa.debian.org/cryptocoin-team/xmrig/-/commit/fa8aaf366f7168be3d30ba9c1d7e5fdaf9bb11bb to get an idea of what is to exclude. Please use the Debian replacements for those libraries. adl and libethash are not yet available (see also #1034528), so please build with WITH_KAWPOW=OFF and WITH_ADL=OFF.
I looked into this when I first started packaging xmrig. Unfortunately,
for many of these third party libraries, Debian's packaging of them
won't work because the version included in xmrig is specially modified
and contains lots of xmrig-specific functions that aren't easy to work
around. For example, many of argon2's functions directly have xmrig in
the name, and work a bit differently to those of the original project.
The source also directly includes headers that exist in the original
source but not a packaged version, and which are also modified
specifically for xmrig. If I were to get rid of all the third party
libraries that don't work easily with Debian's packaged versions, there
wouldn't be much xmrig functionality left.
Thanks,
--
Ben Westover
Ben Westover
Apr 18, 2023, 6:03:29 PM4/18/23
to
Hello,
On 4/18/23 10:18 AM, Bastian Germann wrote:
>> I looked into this when I first started packaging xmrig.
>> Unfortunately, for many of these third party libraries, Debian's
>> packaging of them won't work because the version included in xmrig is
>> specially modified and contains lots of xmrig-specific functions that
>> aren't easy to work around. For example, many of argon2's functions
>> directly have xmrig in the name, and work a bit differently to those
>> of the original project.
>
> The missing thing is hugepages support:
> https://github.com/xmrig/xmrig/commit/b1db0803cfdcb25fd51cef1df2dba46dc63fb0f7
>
> src/crypto/randomx/dataset.cpp relies on some private argon2
> implementation details.
> But as far as I can see you can just have some definitions to satisfy
> these needs.
Ah, I see. I'm very inexperienced with C(++), so I didn't understand how
easy or hard it would be to replace those specifics.
> Either patch or build with WITH_ARGON2=OFF.
I wish I knew how to patch. I would build with argon2 off, but looking
at cmake/randomx.cmake it seems like randomx, essential for mining XMR,
requires argon2 to be enabled.
>> The source also directly includes headers that exist in the original
>> source but not a packaged version, and which are also modified
>> specifically for xmrig. If I were to get rid of all the third party
>> libraries that don't work easily with Debian's packaged versions,
>> there wouldn't be much xmrig functionality left.
>
> The only thing that is not easily replacable from the original list is
> llhttp. Just keep this one. I have done the trivial replacements for CL,
> fmt, and rapidjson. hwloc is built with the system library anyway and
> adl is only used on Windows.
Okay, there's my inexperience again. When I was first packaging this, I
took a look at argon2 and assumed most of the other libraries were as
hard to replace as it. Thanks for showing me how easy it really was.
I've pushed what I have so far to Salsa; unless randomx is disabled, it
won't build without argon2, and I don't know how to patch it. Can you
please help me?
Thanks,
--
Ben Westover
On 4/18/23 10:18 AM, Bastian Germann wrote:
>> I looked into this when I first started packaging xmrig.
>> Unfortunately, for many of these third party libraries, Debian's
>> packaging of them won't work because the version included in xmrig is
>> specially modified and contains lots of xmrig-specific functions that
>> aren't easy to work around. For example, many of argon2's functions
>> directly have xmrig in the name, and work a bit differently to those
>> of the original project.
>
> https://github.com/xmrig/xmrig/commit/b1db0803cfdcb25fd51cef1df2dba46dc63fb0f7
>
> src/crypto/randomx/dataset.cpp relies on some private argon2
> implementation details.
> But as far as I can see you can just have some definitions to satisfy
> these needs.
Ah, I see. I'm very inexperienced with C(++), so I didn't understand how
easy or hard it would be to replace those specifics.
> Either patch or build with WITH_ARGON2=OFF.
I wish I knew how to patch. I would build with argon2 off, but looking
at cmake/randomx.cmake it seems like randomx, essential for mining XMR,
requires argon2 to be enabled.
>> The source also directly includes headers that exist in the original
>> source but not a packaged version, and which are also modified
>> specifically for xmrig. If I were to get rid of all the third party
>> libraries that don't work easily with Debian's packaged versions,
>> there wouldn't be much xmrig functionality left.
>
> llhttp. Just keep this one. I have done the trivial replacements for CL,
> fmt, and rapidjson. hwloc is built with the system library anyway and
> adl is only used on Windows.
Okay, there's my inexperience again. When I was first packaging this, I
took a look at argon2 and assumed most of the other libraries were as
hard to replace as it. Thanks for showing me how easy it really was.
I've pushed what I have so far to Salsa; unless randomx is disabled, it
won't build without argon2, and I don't know how to patch it. Can you
please help me?
Thanks,
--
Ben Westover
Bastian Germann
Apr 19, 2023, 8:10:04 AM4/19/23
to
Am 18.04.23 um 23:48 schrieb Ben Westover:
While there could be a way to patch successfully, it might influence the runtime behaviour significantly,
so you can keep the argon2 as-is.
> I've pushed what I have so far to Salsa; unless randomx is disabled, it won't build without argon2, and I don't know how
> to patch it. Can you please help me?
I have noticed this is a completely different implementation from the argon2 package in Debian.
> to patch it. Can you please help me?
While there could be a way to patch successfully, it might influence the runtime behaviour significantly,
so you can keep the argon2 as-is.
0 new messages