Bug#1013318: pinentry-qt: Dialog window no longer floats under Sway

[Gard Spreemann]

Package: pinentry-qt
X-Debbugs-Cc: gs...@nonempty.org
Version: 1.2.0-1
Severity: normal

Dear Maintainer,

With pinentry-qt 1.1.0-4, running

echo getpin | pinentry-qt --display "Test"

would display a *floating* dialog box under the Sway WM. This is the
desired behavior. As of 1.2.0-1, it instead displays a "full-size"/tiled
window.

I bisected through upstream's later commits, and found that

dd9f765258230cad6704afb4fab6c3deb4a8de56

fixes the problem. I'm including a patch based on

8f239a2b133cae8ca9c1876c732d4e00d06c7d26
7d5c123f802abce11c711d57e8796d58d6ff1a16
dd9f765258230cad6704afb4fab6c3deb4a8de56

(read top to bottom) that I have confirmed fixes the problem. I'll also
place an MR on Salsa.


Best,
Gard

-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.18.0-1-amd64 (SMP w/6 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pinentry-qt depends on:
ii libassuan0 2.5.5-3
ii libc6 2.33-7
ii libgcc-s1 12.1.0-2
ii libgpg-error0 1.45-2
ii libncursesw6 6.3+20220423-2
ii libqt5core5a 5.15.2+dfsg-16+b2
ii libqt5gui5 5.15.2+dfsg-16+b2
ii libqt5widgets5 5.15.2+dfsg-16+b2
ii libstdc++6 12.1.0-2
ii libtinfo6 6.3+20220423-2

pinentry-qt recommends no packages.

Versions of packages pinentry-qt suggests:
pn pinentry-doc <none>

-- no debconf information

[Gard Spreemann]

Daniel Kahn Gillmor <d...@fifthhorseman.net> writes:

> On Thu 2022-06-23 12:24:30 +0200, Gard Spreemann wrote:
>
>> Just needed to wait for my account to be approved. It's done now:
>> https://dev.gnupg.org/T6041
>
> Thanks for this! On that bug report, Ingo linked it to this proposed
> patch from qlyiss on https://dev.gnupg.org/D549 :
>
>
> Index: qt/pinentrydialog.cpp
> ===================================================================
> --- qt/pinentrydialog.cpp
> +++ qt/pinentrydialog.cpp
> @@ -280,6 +280,7 @@
> mainLayout->addLayout(hbox);
> mainLayout->addStretch(1);
> mainLayout->addWidget(buttons);
> + mainLayout->setSizeConstraint(QLayout::SetFixedSize);
>
> auto capsLockWatcher = new CapsLockWatcher{this};
> connect(capsLockWatcher, &CapsLockWatcher::stateChanged,
>
>
> This seems much more narrowly targeted! Gard, can you test this against
> 1.2.0? If you can confirm that it works for you, i'd be happy to patch
> the debian package.

Hah, that is indeed a lot simpler – and I can confirm that it works :-)

Thanks!


Best,
Gard