Bug#1018296: ftpsync: rsync 3.2.5-1 breaks ftpsync

Chris Boot

unread,

Aug 28, 2022, 12:10:03 PM8/28/22

to

Package: ftpsync
Version: 20180513+nmu1
Severity: important

Hi all,

I discussed this a few days ago in #debian-ftp; I think the bug is
probably in rsync but ftpsync is how I ran across it.

My mirror syncs against free.hands.com / ftp.uk.debian.org. With rsync
3.2.5-1 my mirror fails to sync: stage1 executes fine but stage 2 fails
with the following error from rsync:

ERROR: rejecting excluded file-list name: project
rsync error: protocol incompatibility (code 2) at flist.c(994)
[Receiver=3.2.5]
rsync error: protocol incompatibility (code 2) at io.c(1644)
[sender=3.2.3]
(from rsync-ftpsync.error.0)

The ftpsync output around this time is:

Aug 28 07:47:04 tarquin ftpsync[753936]: Running stage2: rsync --quiet
--log-file /srv/debmirror/log/rsync-ftpsync.log
--filter=exclude_/Archive-Update-in-Progress-tarquin.boo.tc
--filter=protect_/Archive-Update-in-Progress-tarquin.boo.tc
--filter=exclude_/Archive-Update-Required-tarquin.boo.tc
--filter=protect_/Archive-Update-Required-tarquin.boo.tc
--filter=exclude_/project/trace/tarquin.boo.tc
--filter=protect_/project/trace/tarquin.boo.tc
--filter=exclude_/project/trace/tarquin.boo.tc-stage1
--filter=protect_/project/trace/tarquin.boo.tc-stage1
--filter=exclude_/project/trace/_hierarchy
--filter=protect_/project/trace/_hierarchy
--filter=exclude_/project/trace/_traces
--filter=protect_/project/trace/_traces --filter=include_/project/
--filter=protect_/project/ --filter=include_/project/trace/
--filter=protect_/project/trace/ --filter=include_/project/trace/*
--bwlimit=0 -prltvHSB8192 --safe-links --chmod=D755,F644 --timeout 120
--stats --no-human-readable --no-inc-recursive --exclude=.~tmp~/
--filter=include_/dists/**/binary-arm64/
--filter=include_/dists/**/installer-arm64/
--filter=include_/dists/**/Contents-arm64.gz
--filter=include_/dists/**/Contents-udeb-arm64.gz
--filter=include_/dists/**/Contents-arm64.diff/
--filter=include_/indices/**/arch-arm64.files
--filter=include_/indices/**/arch-arm64.list.gz
--filter=include_/pool/**/*_arm64.deb
--filter=include_/pool/**/*_arm64.udeb
--filter=include_/pool/**/*_arm64.changes
--filter=include_/dists/**/binary-amd64/
--filter=include_/dists/**/installer-amd64/
--filter=include_/dists/**/Contents-amd64.gz
--filter=include_/dists/**/Contents-udeb-amd64.gz
--filter=include_/dists/**/Contents-amd64.diff/
--filter=include_/indices/**/arch-amd64.files
--filter=include_/indices/**/arch-amd64.list.gz
--filter=include_/pool/**/*_amd64.deb
--filter=include_/pool/**/*_amd64.udeb
--filter=include_/pool/**/*_amd64.changes
--filter=include_/dists/**/binary-i386/
--filter=include_/dists/**/installer-i386/
--filter=include_/dists/**/Contents-i386.gz
--filter=include_/dists/**/Contents-udeb-i386.gz
--filter=include_/dists/**/Contents-i386.diff/
--filter=include_/indices/**/arch-i386.files
--filter=include_/indices/**/arch-i386.list.gz
--filter=include_/pool/**/*_i386.deb
--filter=include_/pool/**/*_i386.udeb
--filter=include_/pool/**/*_i386.changes
--filter=include_/dists/**/source/ --filter=include_/pool/**/*.tar.*
--filter=include_/pool/**/*.diff.* --filter=include_/pool/**/*.dsc
--filter=include_/dists/**/binary-all/
--filter=include_/dists/**/installer-all/
--filter=include_/dists/**/Contents-all.gz
--filter=include_/dists/**/Contents-udeb-all.gz
--filter=include_/dists/**/Contents-all.diff/
--filter=include_/indices/**/arch-all.files
--filter=include_/indices/**/arch-all.list.gz
--filter=include_/pool/**/*_all.deb --filter=include_/pool/**/*_all.udeb
--filter=include_/pool/**/*_all.changes
--filter=exclude_/dists/**/binary-*/
--filter=exclude_/dists/**/installer-*/
--filter=exclude_/dists/**/Contents-*.gz
--filter=exclude_/dists/**/Contents-udeb-*.gz
--filter=exclude_/dists/**/Contents-*.diff/
--filter=exclude_/indices/**/arch-*.files
--filter=exclude_/indices/**/arch-*.list.gz
--filter=exclude_/pool/**/*_*.deb --filter=exclude_/pool/**/*_*.udeb
--filter=exclude_/pool/**/*_*.changes --filter=exclude_/dists/**/source/
--filter=exclude_/pool/**/*.tar.* --filter=exclude_/pool/**/*.diff.*
--filter=exclude_/pool/**/*.dsc free.hands.com::debian
/srv/debmirror/debian/ --max-delete=40000 --delay-updates --delete
--delete-delay --delete-excluded
Aug 28 07:47:41 tarquin ftpsync[753936]: Back from rsync with returncode
2
Aug 28 07:47:41 tarquin ftpsync[753936]: ERROR: Sync step 2 went wrong,
got errorcode 2. Logfile: /srv/debmirror/log/ftpsync.log
Aug 28 07:47:41 tarquin ftpsync[753936]: Mirrorsync done with errors
(from ftpsync.log.0)

The relevant parts of my ftpsync.conf are:

RSYNC_HOST=free.hands.com
RSYNC_PATH="debian"
ARCH_INCLUDE="arm64 amd64 i386 source"

Reverting to rsync 3.2.4-1+b1 allows the sync to complete as normal. The
logs above are from a diffrent machine than the one I'm reporting on
where I have allowed rsync to update to 3.2.5-1, and which I can use for
testing.

Cheers,
Chris

-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (500, 'testing'), (100, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-4-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ftpsync depends on:
ii exim4-daemon-light [mail-transport-agent] 4.96-3
hi rsync 3.2.4-1+b1

Versions of packages ftpsync recommends:
ii curl 7.84.0-2

ftpsync suggests no packages.

-- no debconf information

Lance Albertson

unread,

Sep 2, 2022, 1:30:05 PM9/2/22

to

I have reported a similar bug to RedHat:
https://bugzilla.redhat.com/show_bug.cgi?id=2123815

--
Lance Albertson
Director
Oregon State University | Open Source Lab

Julien Cristau

unread,

Sep 7, 2022, 12:00:04 PM9/7/22

to

On Sun, Aug 28, 2022 at 17:05:10 +0100, Chris Boot wrote:

> Package: ftpsync
> Version: 20180513+nmu1
> Severity: important
>
> Hi all,
>
> I discussed this a few days ago in #debian-ftp; I think the bug is
> probably in rsync but ftpsync is how I ran across it.
>
> My mirror syncs against free.hands.com / ftp.uk.debian.org. With rsync
> 3.2.5-1 my mirror fails to sync: stage1 executes fine but stage 2 fails
> with the following error from rsync:
>
> ERROR: rejecting excluded file-list name: project
> rsync error: protocol incompatibility (code 2) at flist.c(994)
> [Receiver=3.2.5]
> rsync error: protocol incompatibility (code 2) at io.c(1644)
> [sender=3.2.3]
> (from rsync-ftpsync.error.0)
>

On Fri, Sep 2, 2022 at 10:19:01 -0700, Lance Albertson wrote:

> I have reported a similar bug to RedHat:
> https://bugzilla.redhat.com/show_bug.cgi?id=2123815
>

The RH bug points to https://github.com/WayneD/rsync/issues/356 which
seems to confirm this is an rsync bug/regression. Hopefully it can be
fixed soon; I see Samuel is active in the upstream issue.

Cheers,
Julien

Samuel Henrique

unread,

Sep 13, 2022, 4:10:04 PM9/13/22

to

Hello,

I have uploaded rsync 3.2.6-2 to experimental a few minutes ago, it
contains an upstream patch which should fix this as noted on
https://github.com/WayneD/rsync/issues/356

Can you try it out and let upstream know if this addressed the issue, please?

Thank you.

--
Samuel Henrique <samueloph>

Chris Boot

unread,

Sep 21, 2022, 7:50:04 AM9/21/22

to

On 07/09/2022 16:43, Julien Cristau wrote:
> On Fri, Sep 2, 2022 at 10:19:01 -0700, Lance Albertson wrote:
>
>> I have reported a similar bug to RedHat:
>> https://bugzilla.redhat.com/show_bug.cgi?id=2123815
>>
> The RH bug points to https://github.com/WayneD/rsync/issues/356 which
> seems to confirm this is an rsync bug/regression. Hopefully it can be
> fixed soon; I see Samuel is active in the upstream issue.

I've just tried rsync 3.2.6-3 from experimental and can confirm that
ftpsync now works correctly again with that version.

Cheers,
Chris

--
Chris Boot
bo...@debian.org