Bug#1012808: git-review 2.2 is not compatible with OpenSSH 9.X (scp breaking change)

[Baptiste Jonglez]

Package: git-review
Version: 2.2.0-1
Severity: important

Dear Maintainer,

While using git-review on Bookworm, I couldn't perform the initial setup:

$ git review -s -v
Running: scp -P29418 user...@review.opendev.org:hooks/commit-msg .git/hooks/commit-msg
Problems encountered installing commit-msg hook
The following command failed with exit code 255
"scp -P29418 user...@review.opendev.org:hooks/commit-msg .git/hooks/commit-msg"
-----------------------
subsystem request failed on channel 0
scp: Connection closed
-----------------------

Running the scp command manually yields the same error.

This is likely caused by a breaking change in scp behaviour introduced in OpenSSH 9.X

The upstream project already has a fix for this issue:

https://opendev.org/opendev/git-review/commit/5bfaa4a6f355a6820fe16c1aea77a01ba7b97eaa

Updating the git-review package to version 2.3 should be enough to fix this issue.

Thanks,
Baptiste

-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.17.0-1-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages git-review depends on:
ii git 1:2.35.1-1
ii python3 3.10.4-1+b1
ii python3-requests 2.27.1+dfsg-1
ii python3-six 1.16.0-3

git-review recommends no packages.

git-review suggests no packages.

-- no debconf information