Bug#825017: xmms2: equalizer not working

[dave]

Package: xmms2
Version: 0.8+dfsg-15+b3
Severity: normal

Dear Maintainer,

* What led up to the situation?

I installed xmms2 from apt and when using a skin (home made) I could not access equalizer
settings, I also tried the eq.py file from xmms2 client list which also failed. I downloaded
the source for my current version and built the package locally. I received a lot of warning
messages about equalizer, the first being

../src/plugins/equalizer/iir.h:60:16: warning: inline function ‘iir’ declared but never defined

followed by 17 warnings like this but relating to different lines withing the iir_fpu.c file

../src/plugins/equalizer/iir_fpu.c:144:28: warning: ‘data_history2’ is static but used in inline function ‘iir’ which is not static

I could mail the full output of the build if that would help.

I have very little experience of c and therefore cannot offer any fix for this

Dave.

-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.5.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xmms2 depends on:
ii xmms2-client-cli 0.8+dfsg-15+b3
ii xmms2-core 0.8+dfsg-15+b3
ii xmms2-icon 0.8+dfsg-15
ii xmms2-plugin-alsa [xmms2-plugin-output] 0.8+dfsg-15+b3
ii xmms2-plugin-id3v2 0.8+dfsg-15+b3
ii xmms2-plugin-mad 0.8+dfsg-15+b3
ii xmms2-plugin-pulse [xmms2-plugin-output] 0.8+dfsg-15+b3
ii xmms2-plugin-vorbis 0.8+dfsg-15+b3

xmms2 recommends no packages.

xmms2 suggests no packages.

-- no debconf information

[Rémi Vanicat]

dave <dai....@gmail.com> writes:

> Package: xmms2
> Version: 0.8+dfsg-15+b3
> Severity: normal
>
> Dear Maintainer,
>
> * What led up to the situation?
>
> I installed xmms2 from apt and when using a skin (home made)

You meant a home made client? not sure what is a skin in the case of
xmms2.

> I could not access equalizer settings, I also tried the eq.py file
> from xmms2 client list which also failed.

eq.py seem to work here. Is python-xmmsclient installed on your system?
What went wrong with eq.py?

> I downloaded the source for my current version and built the package
> locally. I received a lot of warning messages about equalizer, the
> first being
>
> ../src/plugins/equalizer/iir.h:60:16: warning: inline function ‘iir’ declared but never defined
>
> followed by 17 warnings like this but relating to different lines withing the iir_fpu.c file
>
> ../src/plugins/equalizer/iir_fpu.c:144:28: warning: ‘data_history2’ is static but used in inline function ‘iir’ which is not static
>
> I could mail the full output of the build if that would help.

I've a build log with those warnings. Well, xmms2 is of beta quality,
and there are lot of warnings in the code. It doesn't look like it the
cause of this, but I might be wrong.

--
Rémi Vanicat

[Rémi Vanicat]

Dai <dai....@gmail.com> writes:

> On 22/05/16 17:32, Rémi Vanicat wrote:
>> dave <dai....@gmail.com> writes:
>>
>>> Package: xmms2
>>> Version: 0.8+dfsg-15+b3
>>> Severity: normal
>>>
>>> Dear Maintainer,
>>>
>>> * What led up to the situation?
>>>
>>> I installed xmms2 from apt and when using a skin (home made)
>> You meant a home made client? not sure what is a skin in the case of
>> xmms2.

> Sorry, yes a home made client

>>
>>> I could not access equalizer settings, I also tried the eq.py file
>>> from xmms2 client list which also failed.
>> eq.py seem to work here. Is python-xmmsclient installed on your system?
>> What went wrong with eq.py?

> The equalizer bars do not even display, and I installed promoe from
> the repositories and while it did show the bars and allowed me to
> "turn on" the equalizer, no changes were made to the sound produced.

Okay, more testing show that this is the case for me too.
xmms2.log contain

09:37:22 ERROR: ../src/xmms/plugin.c:375: Failed to open plugin /usr/lib/xmms2/libxmms_equalizer.so: /usr/lib/xmms2/libxmms_equalizer.so: undefined symbol: iir

followed by a lot of

19:26:40 ERROR: ../src/xmms/xform.c:1501: Couldn't find any effect named 'equalizer'

Mmm, could try the attached patches and confirm it fix your problem