Bug#1010535: cyrus-imapd: FTBFS against openssl 3

[Dan Bungert]

Package: cyrus-imapd
Version: 3.6.0~beta2-2
Severity: normal
User: ubuntu...@lists.ubuntu.com
Usertags: origin-ubuntu kinetic

Dear Maintainer,

When building against openssl 3 from experimental, cyrus-imapd will fail in
unit test at build time. This appears to be related to related to the warning
listed at
https://www.openssl.org/docs/man3.0/man3/EVP_PKEY_base_id.html
which suggests using
https://www.openssl.org/docs/man3.0/man3/EVP_PKEY_is_a.html
instead.

In these failing cases, EVP_PKEY_base_id is returning 0, which fails to match
the nid that is being compared against.

I have a patch which converts usage of EVP_PKEY_base_id to EVP_PKEY_is_a, which
allows builds against OpenSSL 3 to pass for both Ubuntu Kinetic and Debian Sid.
Please see attached. I also updated another usage of EVP_PKEY_base_id which I
believe will be incorrect under OpenSSL 3 but that doesn't seem to be caught by
current tests.

Ordinarly at this point I would forward to upstream, but I prefer to do so
first by reproducing the failures with raw upstream source which is is having
unrelated build problems for me. So I'm starting this way.

(also filed at https://launchpad.net/bugs/1971469)

-Dan

[Dan Bungert]

I ended up sending a PR to upstream anyhow, even though it was tested against
the source from Debian. We'll see that they say.

https://github.com/cyrusimap/cyrus-imapd/pull/4075

-Dan