Bug#1054689: therion: FTBFS: utest-proj.cxx:1:10: fatal error: catch2/catch.hpp: No such file or directory

[Martin Budaj]

Thanks, I'll check it out in a week or so.

Martin

On Fri, Oct 27, 2023, 21:21 Lucas Nussbaum <lu...@debian.org> wrote:

Source: therion
Version: 6.1.8-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20231027 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/utest.dir/utest-proj.cxx.o -MF CMakeFiles/utest.dir/utest-proj.cxx.o.d -o CMakeFiles/utest.dir/utest-proj.cxx.o -c /<<PKGBUILDDIR>>/utest-proj.cxx
> /<<PKGBUILDDIR>>/utest-proj.cxx:1:10: fatal error: catch2/catch.hpp: No such file or directory
>     1 | #include <catch2/catch.hpp>
>       |          ^~~~~~~~~~~~~~~~~~
> compilation terminated.
> [113/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thwarppt.cxx.o -MF CMakeFiles/therion-common.dir/thwarppt.cxx.o.d -o CMakeFiles/therion-common.dir/thwarppt.cxx.o -c /<<PKGBUILDDIR>>/thwarppt.cxx
> [114/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion.dir/therion-main.cxx.o -MF CMakeFiles/therion.dir/therion-main.cxx.o.d -o CMakeFiles/therion.dir/therion-main.cxx.o -c /<<PKGBUILDDIR>>/therion-main.cxx
> [115/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thsvg.cxx.o -MF CMakeFiles/therion-common.dir/thsvg.cxx.o.d -o CMakeFiles/therion-common.dir/thsvg.cxx.o -c /<<PKGBUILDDIR>>/thsvg.cxx
> [116/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thtexfonts.cxx.o -MF CMakeFiles/therion-common.dir/thtexfonts.cxx.o.d -o CMakeFiles/therion-common.dir/thtexfonts.cxx.o -c /<<PKGBUILDDIR>>/thtexfonts.cxx
> [117/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thpdf.cxx.o -MF CMakeFiles/therion-common.dir/thpdf.cxx.o.d -o CMakeFiles/therion-common.dir/thpdf.cxx.o -c /<<PKGBUILDDIR>>/thpdf.cxx
> [118/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thwarpp.cxx.o -MF CMakeFiles/therion-common.dir/thwarpp.cxx.o.d -o CMakeFiles/therion-common.dir/thwarpp.cxx.o -c /<<PKGBUILDDIR>>/thwarpp.cxx
> [119/168] /usr/bin/c++ -DFMT_SHARED -DIMG_API_VERSION=1 -DPROJ_VER=9 -DTHLINUX -I/<<PKGBUILDDIR>>/build -I/<<PKGBUILDDIR>> -isystem /usr/include/webp -isystem /<<PKGBUILDDIR>>/extern/quickhull -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -Wall -Wextra -MD -MT CMakeFiles/therion-common.dir/thsymbolset.cxx.o -MF CMakeFiles/therion-common.dir/thsymbolset.cxx.o.d -o CMakeFiles/therion-common.dir/thsymbolset.cxx.o -c /<<PKGBUILDDIR>>/thsymbolset.cxx
> ninja: build stopped: subcommand failed.
> dh_auto_build: error: cd build && LC_ALL=C.UTF-8 ninja -j8 -v returned exit code 1
> make[1]: *** [debian/rules:33: override_dh_auto_build-arch] Error 25


The full build log is available from:
http://qa-logs.debian.net/2023/10/27/therion_6.1.8-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20231027;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20231027&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

[Martin Budaj]

On Thu, Nov 9, 2023 at 3:14 AM Wookey <woo...@wookware.org> wrote:
> On 2023-11-08 20:10 +0100, Martin Budaj wrote:
> > as we still need to maintain Catch2 v2 API compatibility to run CI tests
> > and builds on older Ubuntu images, we can't simply migrate to v3.
>
> Who is building 'latest' Therion on old Ubuntu? And are they getting
> their sources from the Debian unstable package? Or from Upstream?

GitHub Actions has Ubuntu 20.04 and 22.04 images:
https://github.com/actions/runner-images
We use it to run CI tests and to build the official installer.

> > For now, I'll just enable using the bundled Catch2 instead of v3 installed
> > in the system.
>
> That's not the right approach for the Debian package, and this bug is about the debian package.
> Debian unstable has catch 3 in it. We should use it, not an old bundled catch2 copy.
> Upstream builds and Ubuntu builds can do something different if need
> be but that's not a good reason for the Debian package not to
> DTRT. And in general I'd expect current Ubuntu to have catch3 too so
> using the system version will be appropriate there too.

Sure, but to do it properly takes more time then I could currently
dedicate to this, as more changes are required:
- adapt the C++ sources to Catch v3
- introduce #ifs to C++ sources to switch between bundled and system
headers, as v3 names them differently
- modify make and cmake build systems to handle this switching

I plan to do it when time allows (upstream), but for now I think that
it's better to have a workaround than nothing.

Best wishes
Martin