Bug#56419: marked as done ([PATCH] liloconfig fails on DAC960)
Debian Bug Tracking System
with message-id <Pine.LNX.4.20.00012...@v2.ldsol.com>
and subject line Bug#56419: [PATCH] liloconfig fails on DAC960
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Jan 2000 22:42:19 +0000
Received: (qmail 842 invoked from network); 27 Jan 2000 22:42:18 -0000
Received: from va-su-137.valinux.com (HELO tytlal.streaker.org) (209.81.8.137)
by master.debian.org with SMTP; 27 Jan 2000 22:42:18 -0000
Received: from chip by tytlal.streaker.org with local (Exim 3.12 #1 (Debian))
id 12Dx2l-0000rN-00
for <sub...@bugs.debian.org>; Thu, 27 Jan 2000 14:05:35 -0800
Date: Thu, 27 Jan 2000 14:05:35 -0800
From: Chip Salzenberg <ch...@valinux.com>
To: sub...@bugs.debian.org
Subject: [PATCH] liloconfig fails on DAC960
Message-ID: <2000012714...@perlsupport.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Mutt/1.0i
Sender: Chip Salzenberg <ch...@tytlal.perlsupport.com>
Package: lilo
Version: 21-13
Severity: important
Device nodes for the DAC960 are named /dev/rd/c#d# and /dev/rd/c#d#p#,
where "#" is a decimal number. The latest version of liloconfig
chokes because it doesn't expect to have to remove the "p" to
transform a partition device name to a whole-disk device name.
As a result, lilo installation fails on any machine that uses a
DAC960 for its root partition.
Here's a patch that seems to work.
--- liloconfig.distrib Tue Jan 25 06:22:35 2000
+++ liloconfig Thu Jan 27 14:02:53 2000
@@ -102,13 +102,12 @@
if (!$fstab_broken) {
# Valid device/filesystem pair, parse them
- $disk = $device;
- $disk =~ s/[0-9]+$//; # turn '/dev/hda4' into '/dev/hda'...
- $partition = $device;
- $partition =~ s/^$disk//; # ...and '4'
-
# Paranoia check: there should be valid /dev/ nodes for these.
# We could check for block-special-device-ness, but perhaps
# some people have symlink forests in /dev/ ?
- $fstab_broken = 1 unless ($partition =~ /^[0-9]+$/ && -e $disk && -e $device);
+
+ unless (($disk, $partition) = ($device =~ /^(.*?)p?(\d+)$/)
+ && -e $device && -e $disk) {
+ $fstab_broken = 1;
+ }
}
--
Chip Salzenberg - a.k.a. - <ch...@valinux.com>
"He's Mr. Big of 'Big And Tall' fame." // MST3K
---------------------------------------
Received: (at 56419-done) by bugs.debian.org; 29 Jan 2000 22:42:27 +0000
Received: (qmail 14363 invoked from network); 29 Jan 2000 22:42:27 -0000
Received: from s3.smtp.oleane.net (195.25.12.10)
by master.debian.org with SMTP; 29 Jan 2000 22:42:26 -0000
Received: from vince.ldsol.com (unknown [62.161.210.241])
by s3.smtp.oleane.net (Postfix) with ESMTP
id 8013821397; Sat, 29 Jan 2000 23:42:24 +0100 (CET)
Received: from v2.ldsol.com [192.168.1.100] (mail)
by vince.ldsol.com with esmtp
id 12Eg5j-0005Rz-00 (Linux Rulez); Sat, 29 Jan 2000 23:11:39 +0100
Received: from vincent by v2.ldsol.com with local-esmtp (Exim 3.12 #1 (Debian))
id 12EgYS-0000vo-00; Sat, 29 Jan 2000 23:41:20 +0100
Date: Sat, 29 Jan 2000 22:41:20 +0000 (GMT)
From: Vincent Renardias <vin...@debian.org>
X-Sender: vin...@v2.ldsol.com
To: Chip Salzenberg <ch...@valinux.com>, 56419...@bugs.debian.org
Subject: Re: Bug#56419: [PATCH] liloconfig fails on DAC960
In-Reply-To: <200001291...@perlsupport.com>
Message-ID: <Pine.LNX.4.20.00012...@v2.ldsol.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: Vincent Renardias <vin...@ldsol.com>
On Sat, 29 Jan 2000, Chip Salzenberg wrote:
> According to Vincent Renardias:
> > Can you please try the 21-14 (in the archive since yesterday) and tell me
> > if it fixes your problem?
>
> Yup. Thanks.
# good. ;)
$Lilo::my_bugs--;
Cordialement,
--
- Vincent RENARDIAS vincent@{{ldsol,pipo}.com,{debian,openhardware}.org} -
- Debian/GNU Linux: GNOME : -
- http://www.fr.debian.org http://www.gnome.org -
---------------------------------------------------------------------------
"Every man has two nations, and one of them is France" [Benjamin Franklin]
--
To UNSUBSCRIBE, email to debian-bugs-c...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org