pinctrl v5.6.0-rc1: no USB after "ARM: dts: sunxi: Remove pinctrl groups setting bias" on "sun7i-a20-olinuxino-lime.dts"

[Oleg Verych]

Hello, linux-sunxi!

When building 5.6.0-rc1 and successfully booting it on A20-Olinuxino-Lime,
USB HID keyboard stops working, while it's OK on U-Boot.

dmesg error :

```
[] sun4i-pinctrl 1c20800.pinctrl: 1c20800.pinctrl supply vcc-pin not found, using dummy regulator
[] sun4i-usb-phy 1c13400.phy: Couldn't request ID GPIO
[] sun4i-usb-phy: probe of 1c13400.phy failed with error -22
```

failing patch:

ARM: dts: sunxi: Remove pinctrl groups setting bias
https://github.com/linux-sunxi/linux-sunxi/commit/a107bd2b6b63d510fecc402657f627dcfb205c89#diff-d57935e9e5af2884e729d4c254a17fee


USB is OK when using prev. commit file from:

mripard ARM: sunxi: Fix the USB PHY VBUS detect GPIO properties

https://github.com/linux-sunxi/linux-sunxi/blob/033914f877e8d1febf802242174a62ce566a5901/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts


There is nothing 'sun4i-usb-phy' like in `dmesg` output, but lots of "USB hub found" messages.

--
sed 'sh && sed && node.js + olecom = happiness and mirth' << ''
-o--=O`C
#oo'L O
<___=E M

[Clément Péron]

Hi, 

You should add sunxi Maintainer and commit author. 

Linux-sunxi is not the official mainlining list.

Regards,

Clément

--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/71bf76cd-bc2a-4281-b57a-ddae4b9463c2%40googlegroups.com.

[Clément Péron]

There is a typo,

missing the 's' at gpio

- usb0_id_det-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
- usb0_vbus_det-gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
+ usb0_id_det-gpio   = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+ usb0_vbus_det-gpios = <&pio 7 5 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH5 */

Clement

[Clément Péron]

A fix has been pushed in v5.6-rc5

https://github.com/torvalds/linux/commit/15a48503ccd8db4da9bf1e80ed01401b64e18d30#diff-e1c95aa5c1a33cdd6bd89a7ce910d4b2  

[Oleg Verych]

Hello, Clément! Thanks for pointing this message into right way.

2020-03-10 2:27 GMT+03:00, Clément Péron <peron...@gmail.com>:
> A fix has been pushed in v5.6-rc5
> https://github.com/torvalds/linux/commit/15a48503ccd8db4da9bf1e80ed01401b64e18d30#diff-e1c95aa5c1a33cdd6bd89a7ce910d4b2
>

That change relates to DT file

sun4i-a10-olinuxino-lime.dts

while issue relates to

sun7i-a20-olinuxino-lime.dts

Thus, let me repeat:

> When building 5.6.0-rc1 and successfully booting it on
> A20-Olinuxino-Lime,
> USB HID keyboard stops working, while it's OK on U-Boot.
>
> dmesg error :
>
> ```
> [] sun4i-pinctrl 1c20800.pinctrl: 1c20800.pinctrl supply vcc-pin not
> found, using dummy regulator
> [] sun4i-usb-phy 1c13400.phy: Couldn't request ID GPIO
> [] sun4i-usb-phy: probe of 1c13400.phy failed with error -22
> ```
>
> failing patch:
>
> ARM: dts: sunxi: Remove pinctrl groups setting bias
>
> https://github.com/linux-sunxi/linux-sunxi/commit/a107bd2b6b63d510fecc402657f627dcfb205c89#diff-d57935e9e5af2884e729d4c254a17fee
>
>
> USB is OK when using prev. commit file from:
>
> mripard ARM: sunxi: Fix the USB PHY VBUS detect GPIO properties
>
>
> https://github.com/linux-sunxi/linux-sunxi/blob/033914f877e8d1febf802242174a62ce566a5901/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts
>

_____________

[Oleg Verych]

Hello!

I've got newer A20 Olinuxino-lime2 board.
Same problem there, no USB (keyboard at least):

```
ssh root...
root@lime2:/boot# dmesg | grep 'sun4i-usb-phy'
[ 0.645014] sun4i-usb-phy 1c13400.phy: Couldn't request ID GPIO
[ 0.971274] sun4i-usb-phy 1c13400.phy: Couldn't request ID GPIO
[ 0.971321] sun4i-usb-phy: probe of 1c13400.phy failed with error -22
root@lime2:/boot# uname -a
Linux lime2 5.6.0-rc1-olimex-2020-gbdb5d1a70 #6 SMP Fri Feb 21
18:21:51 +03 2020 armv7l armv7l armv7l GNU/Linux
root@lime2:/boot# cat /etc/issue
Armbian 20.02.1 Bionic
```

DT file: sun7i-a20-olinuxino-lime2.dts