[PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support

[Samuel Holland]

This series allows the volume keys on the PinePhone to wake up the
device. As pointed out for v1, wakeup should only be enabled when a
"wakeup-source" property is present, so v2 requires DT and binding
changes in addition to the driver change.

Changes since v1:
- Add requisite DT binding change
- Only add wakeup capability if "wakeup-source" is present
- Warn but do not error out if setting the wake IRQ fails
- Add "wakeup-source" property to PinePhone device tree

Ondrej Jirman (1):
input: sun4i-lradc-keys - Add wakup support

Samuel Holland (2):
dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property
arm64: dts: allwinner: pinephone: Support volume key wakeup

.../input/allwinner,sun4i-a10-lradc-keys.yaml | 2 ++
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 1 +
drivers/input/keyboard/sun4i-lradc-keys.c | 22 +++++++++++++++----
3 files changed, 21 insertions(+), 4 deletions(-)

--
2.26.2

[Hans de Goede]

Hi,

On 1/13/21 5:05 AM, Samuel Holland wrote:
> This series allows the volume keys on the PinePhone to wake up the
> device. As pointed out for v1, wakeup should only be enabled when a
> "wakeup-source" property is present, so v2 requires DT and binding
> changes in addition to the driver change.
>
> Changes since v1:
> - Add requisite DT binding change
> - Only add wakeup capability if "wakeup-source" is present
> - Warn but do not error out if setting the wake IRQ fails
> - Add "wakeup-source" property to PinePhone device tree
>
> Ondrej Jirman (1):
> input: sun4i-lradc-keys - Add wakup support
>
> Samuel Holland (2):
> dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property
> arm64: dts: allwinner: pinephone: Support volume key wakeup

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdeg...@redhat.com>

Regards,

Hans

[Maxime Ripard]

Acked-by: Maxime Ripard <mri...@kernel.org>

I've applied patch 3

Maxime