Re: [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header
16 views
Skip to first unread message
Herbert Xu
Apr 16, 2020, 2:07:19 AM4/16/20
to Corentin Labbe, da...@davemloft.net, mri...@kernel.org, we...@csie.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux-...@vger.kernel.org, linux...@googlegroups.com
On Fri, Apr 03, 2020 at 07:50:32PM +0000, Corentin Labbe wrote:
> This patch add __crypto_rng_cast() to the rng header like other
> __algo_cast functions.
>
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>
> ---
> include/crypto/rng.h | 5 +++++
> 1 file changed, 5 insertions(+)
This should never be exported. Either change the driver to use
use crypto_tfm_ctx instead of crypto_rng_ctx, or if you have the
time please convert the rng API over to the new way of doing things
like aead/skcipher.
Thanks,
--
Email: Herbert Xu <her...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> This patch add __crypto_rng_cast() to the rng header like other
> __algo_cast functions.
>
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>
> ---
> include/crypto/rng.h | 5 +++++
> 1 file changed, 5 insertions(+)
This should never be exported. Either change the driver to use
use crypto_tfm_ctx instead of crypto_rng_ctx, or if you have the
time please convert the rng API over to the new way of doing things
like aead/skcipher.
Thanks,
--
Email: Herbert Xu <her...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Reply all
Reply to author
Forward
0 new messages