SUNXI-GMAC driver logs every vlan frame...

[Eddy Beaupre]

Hello!

Don't know if i'm the only one who's using vlan with sunxi-gmac, but the
current driver is terribly spammy for the logs, it log every single vlan
frame at the INFO level. Personally i don't think that information is
useful at all but if you want to keep it enable, it should log it at the
DEBUG level instead. So i propose this little simple modification to the
source (or better, remove the whole line.):

diff --git a/drivers/net/ethernet/allwinner/gmac/gmac_desc.c
b/drivers/net/ethernet/allwinner/gmac/gmac_desc.c
index 57ae52f..c34f033 100644
--- a/drivers/net/ethernet/allwinner/gmac/gmac_desc.c
+++ b/drivers/net/ethernet/allwinner/gmac/gmac_desc.c
@@ -49,7 +49,7 @@ int desc_get_tx_status(void *data, struct
gmac_extra_stats *x,
}

if (p->desc0.tx.vlan_tag) {
- printk(KERN_INFO "GMAC TX status: VLAN frame\n");
+ pr_debug("GMAC TX status: VLAN frame\n");
x->tx_vlan++;
}



Thanks!

[Eddy Beaupre]

Hello again :)

I have made a driver for the Ampak AP6210 WiFi/Bluetooth module found on
the Cubietruck, basically it's the driver found in the 3.79+ kernel
distributed by CubieTech, but with all the rfkill stuff moved back into
the module itself, lots of cleanup in its logging so it doesn't spam the
kernel log anymore and no proprietary/unreleased headers.

The driver source and patch is available in my git :

https://github.com/EddyBeaupre/ap6210

I know it would have been better to merge it with the bcmdhd driver, but
since it's so specific to one implementation, it would need a lot of
rework to make it configurable. It's at least a starting point.

The only major bug so far is it can't be rmmod cleanly because the
rfkill stuff was never supposed to be unloaded. But it's not a major
show stopper for general usage. I will work on that when i have more time.

Hope this help.

[Luc Verhaegen]

Please create the bluetooth wiki page

http://linux-sunxi.org/index.php?title=Bluetooth&action=edit

and all relevant information there. This will ensure maximum exposure
for your work.

Luc Verhaegen.

[Julian Calaby]

Hi Eddy,

Nice work, but I believe Hans de Goede is already working on extending
the upstream Brcmfmac driver to support that chip.

(side note: I believe that the bcmdhd driver is slowly being replaced
by the upstream brcmfmac driver)

You might want to investigate his work on that, if you're using a
non-upstream kernel, the backports project might be helpful.

Thanks,

--
Julian Calaby

Email: julian...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

[Eddy Beaupré]

That's why i made this interim driver, i know it will be short lived but it make things work until Hans get his driver ready. :)

[Hans de Goede]

Hi,

On 06/05/2014 04:01 PM, Eddy Beaupré wrote:
> That's why i made this interim driver, i know it will be short lived but it make things work until Hans get his driver ready. :)

Note that I've no plans to backport brcmfmac to 3.4, so if people
want to have it for the 3.4 kernels they will need to do the
backporting themselves.

Regards,

Hans

[Eddy Beaupré]

That's something i will probably work on if brcmfmac goes into mainstream linux, for now, this driver does the job. It's not the best solution but 3.4 is a temporary solution anyway until mainstream can take over.

[Hans de Goede]

Hi,

brcmfmac is already in mainstream and works with the AP6210 there.

Regards,

Hans

[Alejandro Mery]

sorry for the delay. applied to stage/sunxi-3.4

thank you!
Alejandro Mery

[stefan....@gmail.com]

Hi will the ap6210 in mainline work on banana pro too? I got no wifi working there

[sokd...@gmail.com]

Hi... Has anyone made an android firmware/ image which supports the combination of Allwinner A20 + Ap6210. I have a mini pc which is powered by an Allwinner a20 processor and has an AP6210 wifi module. I have tried to flash my original image with a better one (unfortunately i did not make back up first), and now any image i flash, the wifi will not work.. I have flashed really good android and linux images like the cubieeboard but always the wifi is a problem... I can see here that some have been working to add support of the ap6210 on these boards.. Has anyone done it? Can someone share a ready image pls (a20+ap6210 support).. I have been searching for months with no results... and i don't have the knowledge to do it myself :(