Chen-Yu Tsai
unread,Jul 31, 2019, 4:43:33 AM7/31/19Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Stefan Mavrodiev, Srinivas Kandagatla, Maxime Ripard, moderated list:ARM/Allwinner sunXi SoC support, open list, linux-sunxi
On Wed, Jul 31, 2019 at 3:15 PM Stefan Mavrodiev <
ste...@olimex.com> wrote:
>
> Like in H3, A64 SID controller doesn't return correct data
> when using direct access. It appears that on A64, SID needs
> 8 bytes of word_size.
>
> Workaround is to enable read by registers.
>
> Signed-off-by: Stefan Mavrodiev <
ste...@olimex.com>
Acked-by: Chen-Yu Tsai <
we...@csie.org>
And for single patches, you don't need to write a separate cover letter.
Just put whatever you need to add after the "---" separator.
> ---
> drivers/nvmem/sunxi_sid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
> index a079a80ddf2c..e26ef1bbf198 100644
> --- a/drivers/nvmem/sunxi_sid.c
> +++ b/drivers/nvmem/sunxi_sid.c
> @@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = {
> static const struct sunxi_sid_cfg sun50i_a64_cfg = {
> .value_offset = 0x200,
> .size = 0x100,
> + .need_register_readout = true,
> };
>
> static const struct sunxi_sid_cfg sun50i_h6_cfg = {
> --
> 2.17.1
>