[PATCH] arm64: dts: allwinner: h6: PineH64 model B: Add wifi

52 views
Skip to first unread message

Jernej Skrabec

unread,
Oct 29, 2020, 4:10:14 PM10/29/20
to mri...@kernel.org, we...@csie.org, rob...@kernel.org, devic...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux...@googlegroups.com
PineH64 model B contains RTL8723CS wifi+bt combo module.

Since bluetooth support is not yet squared away, only wifi is enabled
for now.

Signed-off-by: Jernej Skrabec <jernej....@siol.net>
---
.../dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
index f4c8966a6497..3f42b8b29b0f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
@@ -10,6 +10,12 @@ / {
compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6";

/delete-node/ reg_gmac_3v3;
+
+ wifi_pwrseq: wifi_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
+ post-power-on-delay-ms = <200>;
+ };
};

&hdmi_connector {
@@ -19,3 +25,11 @@ &hdmi_connector {
&emac {
phy-supply = <&reg_aldo2>;
};
+
+&mmc1 {
+ vmmc-supply = <&reg_cldo3>;
+ mmc-pwrseq = <&wifi_pwrseq>;
+ bus-width = <4>;
+ non-removable;
+ status = "okay";
+};
--
2.29.1

Chen-Yu Tsai

unread,
Oct 29, 2020, 10:26:20 PM10/29/20
to Jernej Skrabec, Maxime Ripard, Rob Herring, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
Please add vqmmc-supply, which according to the schematic is supplied by ALDO1.

After that,

Acked-by: Chen-Yu Tsai <we...@csie.org>

> + mmc-pwrseq = <&wifi_pwrseq>;
> + bus-width = <4>;
> + non-removable;
> + status = "okay";
> +};
> --
> 2.29.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201029201537.598182-1-jernej.skrabec%40siol.net.

Jernej Skrabec

unread,
Oct 30, 2020, 1:20:04 PM10/30/20
to mri...@kernel.org, we...@csie.org, rob...@kernel.org, devic...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux...@googlegroups.com
PineH64 model B contains RTL8723CS wifi+bt combo module.

Since bluetooth support is not yet squared away, only wifi is enabled
for now.

Acked-by: Chen-Yu Tsai <we...@csie.org>
Signed-off-by: Jernej Skrabec <jernej....@siol.net>
---
Changes from v1:
- added Chen-Yu tag
- added vqmmc-supply

.../dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
index f4c8966a6497..7fea1e4e2d49 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
@@ -10,6 +10,12 @@ / {
compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6";

/delete-node/ reg_gmac_3v3;
+
+ wifi_pwrseq: wifi_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
+ post-power-on-delay-ms = <200>;
+ };
};

&hdmi_connector {
@@ -19,3 +25,12 @@ &hdmi_connector {
&emac {
phy-supply = <&reg_aldo2>;
};
+
+&mmc1 {
+ vmmc-supply = <&reg_cldo3>;
+ vqmmc-supply = <&reg_aldo1>;

Corentin Labbe

unread,
Oct 31, 2020, 5:12:58 PM10/31/20
to Jernej Skrabec, mri...@kernel.org, we...@csie.org, rob...@kernel.org, devic...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux...@googlegroups.com
Hello

Tested-by: <clabbe....@gmail.com>
RTL8723CS driver probe and related iwlist commands works. (like listing availlable channels)
But connecting to a wireless network was not successfully tested yet. (I need to set a test network).

Regards

Maxime Ripard

unread,
Nov 2, 2020, 5:23:17 AM11/2/20
to Jernej Skrabec, we...@csie.org, rob...@kernel.org, devic...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux...@googlegroups.com
On Fri, Oct 30, 2020 at 06:25:30PM +0100, Jernej Skrabec wrote:
> PineH64 model B contains RTL8723CS wifi+bt combo module.
>
> Since bluetooth support is not yet squared away, only wifi is enabled
> for now.
>
> Acked-by: Chen-Yu Tsai <we...@csie.org>
> Signed-off-by: Jernej Skrabec <jernej....@siol.net>

Applied, thanks!
Maxime
signature.asc
Reply all
Reply to author
Forward
0 new messages