[PATCH] ntb: fix SKX NTB config space size register offsets

7 views
Skip to first unread message

Dave Jiang

unread,
Dec 13, 2016, 11:03:15 AM12/13/16
to Allen...@emc.com, jdm...@kudzu.us, linu...@googlegroups.com, Sandeep Mann, Zachary Ross
The offsets for the SZ registers are wrong. Updated.

Signed-off-by: Dave Jiang <dave....@intel.com>
Reported-by: Sandeep Mann <san...@purestorage.com>
Tested-by: Zachary Ross <zachar...@intel.com>
---
drivers/ntb/hw/intel/ntb_hw_intel.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h b/drivers/ntb/hw/intel/ntb_hw_intel.h
index 6e8c182..f2cf8a7 100644
--- a/drivers/ntb/hw/intel/ntb_hw_intel.h
+++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
@@ -152,10 +152,10 @@
#define XEON_SPAD_COUNT 16

/* Intel Skylake Xeon hardware */
-#define SKX_IMBAR1SZ_OFFSET 0x00d1
-#define SKX_IMBAR2SZ_OFFSET 0x00d5
-#define SKX_EMBAR1SZ_OFFSET 0x00d3
-#define SKX_EMBAR2SZ_OFFSET 0x00d6
+#define SKX_IMBAR1SZ_OFFSET 0x00d0
+#define SKX_IMBAR2SZ_OFFSET 0x00d1
+#define SKX_EMBAR1SZ_OFFSET 0x00d2
+#define SKX_EMBAR2SZ_OFFSET 0x00d3
#define SKX_DEVCTRL_OFFSET 0x0098
#define SKX_DEVSTS_OFFSET 0x009a
#define SKX_UNCERRSTS_OFFSET 0x014c

Jon Mason

unread,
Dec 21, 2016, 11:54:17 AM12/21/16
to Dave Jiang, Allen...@emc.com, linu...@googlegroups.com, Sandeep Mann, Zachary Ross
On Tue, Dec 13, 2016 at 09:03:13AM -0700, Dave Jiang wrote:
> The offsets for the SZ registers are wrong. Updated.
>
> Signed-off-by: Dave Jiang <dave....@intel.com>
> Reported-by: Sandeep Mann <san...@purestorage.com>
> Tested-by: Zachary Ross <zachar...@intel.com>

Applied to my ntb branch

Thanks,
Jon

> ---
> drivers/ntb/hw/intel/ntb_hw_intel.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h b/drivers/ntb/hw/intel/ntb_hw_intel.h
> index 6e8c182..f2cf8a7 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.h
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
> @@ -152,10 +152,10 @@
> #define XEON_SPAD_COUNT 16
>
> /* Intel Skylake Xeon hardware */
> -#define SKX_IMBAR1SZ_OFFSET 0x00d1
> -#define SKX_IMBAR2SZ_OFFSET 0x00d5
> -#define SKX_EMBAR1SZ_OFFSET 0x00d3
> -#define SKX_EMBAR2SZ_OFFSET 0x00d6
> +#define SKX_IMBAR1SZ_OFFSET 0x00d0
> +#define SKX_IMBAR2SZ_OFFSET 0x00d1
> +#define SKX_EMBAR1SZ_OFFSET 0x00d2
> +#define SKX_EMBAR2SZ_OFFSET 0x00d3
> #define SKX_DEVCTRL_OFFSET 0x0098
> #define SKX_DEVSTS_OFFSET 0x009a
> #define SKX_UNCERRSTS_OFFSET 0x014c
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+...@googlegroups.com.
> To post to this group, send email to linu...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/148164499341.194663.8632238363765425811.stgit%40djiang5-desk3.ch.intel.com.
> For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages