[PATCH 1/2] watchdog: Staticise nuc900_wdt

2 views
Skip to first unread message

Axel Lin

unread,
Jan 17, 2012, 9:45:20 PM1/17/12
to linux-...@vger.kernel.org, Wan ZongShun, Wim Van Sebroeck, linux-w...@vger.kernel.org
It is only used in this driver, so no need to make the symbol global.

Signed-off-by: Axel Lin <axel...@gmail.com>
---
drivers/watchdog/nuc900_wdt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/watchdog/nuc900_wdt.c b/drivers/watchdog/nuc900_wdt.c
index 50359ba..2cce856 100644
--- a/drivers/watchdog/nuc900_wdt.c
+++ b/drivers/watchdog/nuc900_wdt.c
@@ -72,7 +72,7 @@ struct nuc900_wdt {
};

static unsigned long nuc900wdt_busy;
-struct nuc900_wdt *nuc900_wdt;
+static struct nuc900_wdt *nuc900_wdt;

static inline void nuc900_wdt_keepalive(void)
{
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Axel Lin

unread,
Jan 17, 2012, 9:46:52 PM1/17/12
to linux-...@vger.kernel.org, Wan ZongShun, Wim Van Sebroeck, linux-w...@vger.kernel.org
Return proper error instead of 0 if misc_register fails

Signed-off-by: Axel Lin <axel...@gmail.com>
---

drivers/watchdog/nuc900_wdt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/watchdog/nuc900_wdt.c b/drivers/watchdog/nuc900_wdt.c
index 2cce856..529085b 100644
--- a/drivers/watchdog/nuc900_wdt.c
+++ b/drivers/watchdog/nuc900_wdt.c
@@ -287,7 +287,8 @@ static int __devinit nuc900wdt_probe(struct platform_device *pdev)

setup_timer(&nuc900_wdt->timer, nuc900_wdt_timer_ping, 0);

- if (misc_register(&nuc900wdt_miscdev)) {
+ ret = misc_register(&nuc900wdt_miscdev);
+ if (ret) {
dev_err(&pdev->dev, "err register miscdev on minor=%d (%d)\n",
WATCHDOG_MINOR, ret);
goto err_clk;

Reply all
Reply to author
Forward
0 new messages