ANDN and Group 17 in x86-opcode-map.txt

5 views
Skip to first unread message

Ulrich Drepper

unread,
Jan 17, 2012, 2:14:02 PM1/17/12
to Masami Hiramatsu, Linux Kernel Mailing List, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x...@kernel.org, pp-ma...@sdl.hitachi.co.jp
The Intel documentation at

http://software.intel.com/file/36945

shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
respectively. The current version of x86-opcode-map.txt shows them
with f3 and f4. Unless someone can point to documentation which shows
the currently used encoding the following patch be applied.

Signed-off-by: Ulrich Drepper <dre...@gmail.com>

diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt
index 5b83c51..4c8010d 100644
--- a/arch/x86/lib/x86-opcode-map.txt
+++ b/arch/x86/lib/x86-opcode-map.txt
@@ -729,8 +729,8 @@ de: VAESDEC Vdq,Hdq,Wdq (66),(v1)
df: VAESDECLAST Vdq,Hdq,Wdq (66),(v1)
f0: MOVBE Gy,My | MOVBE Gw,Mw (66) | CRC32 Gd,Eb (F2)
f1: MOVBE My,Gy | MOVBE Mw,Gw (66) | CRC32 Gd,Ey (F2)
-f3: ANDN Gy,By,Ey (v)
-f4: Grp17 (1A)
+f2: ANDN Gy,By,Ey (v)
+f3: Grp17 (1A)
f5: BZHI Gy,Ey,By (v) | PEXT Gy,By,Ey (F3),(v) | PDEP Gy,By,Ey (F2),(v)
f6: MULX By,Gy,rDX,Ey (F2),(v)
f7: BEXTR Gy,Ey,By (v) | SHLX Gy,Ey,By (66),(v) | SARX Gy,Ey,By
(F3),(v) | SHRX Gy,Ey,By (F2),(v)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

H. Peter Anvin

unread,
Jan 17, 2012, 2:21:51 PM1/17/12
to Ulrich Drepper, Masami Hiramatsu, Linux Kernel Mailing List, Thomas Gleixner, Ingo Molnar, x...@kernel.org, pp-ma...@sdl.hitachi.co.jp
On 01/17/2012 11:14 AM, Ulrich Drepper wrote:
> The Intel documentation at
>
> http://software.intel.com/file/36945
>
> shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
> respectively. The current version of x86-opcode-map.txt shows them
> with f3 and f4. Unless someone can point to documentation which shows
> the currently used encoding the following patch be applied.
>
> Signed-off-by: Ulrich Drepper <dre...@gmail.com>
>

Looks right to me. Masami, I assume this was just a transcription error?

Acked-by: H. Peter Anvin <h...@zytor.com>


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

tip-bot for Ulrich Drepper

unread,
Jan 17, 2012, 5:43:37 PM1/17/12
to linux-ti...@vger.kernel.org, linux-...@vger.kernel.org, h...@zytor.com, mi...@redhat.com, dre...@gmail.com, tg...@linutronix.de
Commit-ID: ce79dac861e0d9a473d9923391bdbaad83c1c57f
Gitweb: http://git.kernel.org/tip/ce79dac861e0d9a473d9923391bdbaad83c1c57f
Author: Ulrich Drepper <dre...@gmail.com>
AuthorDate: Tue, 17 Jan 2012 14:14:02 -0500
Committer: H. Peter Anvin <h...@zytor.com>
CommitDate: Tue, 17 Jan 2012 12:11:54 -0800

x86, opcode: ANDN and Group 17 in x86-opcode-map.txt

The Intel documentation at

http://software.intel.com/file/36945

shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
respectively. The current version of x86-opcode-map.txt shows them
with f3 and f4. Unless someone can point to documentation which shows
the currently used encoding the following patch be applied.

Signed-off-by: Ulrich Drepper <dre...@gmail.com>
Link: http://lkml.kernel.org/r/CAOPLpQdq5SuVo9=023CYhbFLAX9rONyj...@mail.gmail.com
Signed-off-by: H. Peter Anvin <h...@zytor.com>
---
arch/x86/lib/x86-opcode-map.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Masami Hiramatsu

unread,
Jan 17, 2012, 10:08:40 PM1/17/12
to H. Peter Anvin, Ulrich Drepper, Linux Kernel Mailing List, Thomas Gleixner, Ingo Molnar, x...@kernel.org, pp-ma...@sdl.hitachi.co.jp, yrl.pp-m...@hitachi.com
(2012/01/18 4:21), H. Peter Anvin wrote:
> On 01/17/2012 11:14 AM, Ulrich Drepper wrote:
>> The Intel documentation at
>>
>> http://software.intel.com/file/36945
>>
>> shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
>> respectively. The current version of x86-opcode-map.txt shows them
>> with f3 and f4. Unless someone can point to documentation which shows
>> the currently used encoding the following patch be applied.
>>
>> Signed-off-by: Ulrich Drepper <dre...@gmail.com>
>>
>
> Looks right to me. Masami, I assume this was just a transcription error?
>
> Acked-by: H. Peter Anvin <h...@zytor.com>

Oh! right, it must be my typo.

Acked-by: Masami Hiramatsu <masami.hi...@hitachi.com>

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hi...@hitachi.com

Reply all
Reply to author
Forward
0 new messages