LIO-Target Core v3.0.0 imported in k.o git

3 views
Skip to first unread message

Nicholas A. Bellinger

unread,
May 20, 2008, 6:48:17 PM5/20/08
to Linux-iSCSI.org Target Dev, LKML, linux-scsi, Open iSCSI, OpenFabrics-General, n...@kernel.org, Ming Zhang, Ross S. W. Walker, FUJITA Tomonori, Mike Christie, Vladislav Bolkhovitin, Christoph Hellwig, Jens Axboe, Grant Grundler, Mike Mazarick, Bryan Black, Sig Lange, Hannes Reinecke
Greetings all,

The LIO-Target Core v3.0.0 tree has been imported from v2.9-STABLE from
Linux-iSCSI.org source tree repositories into kernel.org git, and is
building w/ v2.6.26-rc3. It can be found at:

http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=summary

I will be continuing the cleanup activies for upstream, which so far has
included the removal of legacy unused engine level mirroring/replication
bits (as we are using LIO-DRBD or LIO-NR1 w/ MD for this now), and a few
LINUX_VERSION_CODE removals.

[nab@hera lio-core]$ wc -l *.c *.h | tail -n 1
57879 total

The goal now will be to seperate out the LIO-Target / LIO-Core pieces
for moving the latter upstream initially (eg a working passthrough, and
then v3.0 LIO-Target using traditional iSCSI, then iWARP and iSER. This
will all be going into the roadmap on Linux-iSCSI.org for reference.

I invite interested parties to have a look, and please contact me on the
LIO-Target devel list, or privately if you would like to get involved
looking at some code that are in line with your
knowledge/interests/projects.

Many thanks for your most valuable of time,

--nab


Nicholas A. Bellinger

unread,
Jun 5, 2008, 3:12:05 PM6/5/08
to markbirss, Linux-iSCSI.org Target Dev
Hi Mark!

On Thu, 2008-06-05 at 10:22 -0700, markbirss wrote:
> Nab
>
> I obtained a git copy of lio-core-2.6 but have the follow kernel
> error:
>
> "
> Jun 4 23:26:16 cell kernel: Linux-iSCSI.org iSCSI Target Core Stack
> v3.0.0 on Linux/ppc64 on 2.6.26-rc3
> Jun 4 23:26:16 cell kernel: SE: fp_auto_assign: 0
> Jun 4 23:26:16 cell kernel: iscsi_target_detect:1075: ***ERROR***
> create_proc_info_entry() failed.
> "
> Can you possible help with this problem ?
>

Ok, so when I was working on this last week, I was using kernel.org for
patching and compiling. And did not quite get to testing it just yet.

Anyways, lemme get v3.0 into a v2.6.23-rc3 VM this afternoon and make
sure that things work as expected and I will resolve this PROC breakage
too.

--nab

PS: Please join the list:

http://groups.google.com/group/linux-iscsi-target-dev

as there will be some very interesting discussions coming through today
on this new project that Jerome Martin and myself have been working on
wrt cloud computing. :-) Anyways, have a look.

> Regards
> Mark
>
>
> On May 21, 12:48 am, "Nicholas A. Bellinger" <n...@linux-iscsi.org>

Nicholas A. Bellinger

unread,
Jun 5, 2008, 4:11:06 PM6/5/08
to linux-iscsi...@googlegroups.com, markbirss
Hi again,

On Thu, 2008-06-05 at 12:12 -0700, Nicholas A. Bellinger wrote:
> Hi Mark!
>
> On Thu, 2008-06-05 at 10:22 -0700, markbirss wrote:
> > Nab
> >
> > I obtained a git copy of lio-core-2.6 but have the follow kernel
> > error:
> >
> > "
> > Jun 4 23:26:16 cell kernel: Linux-iSCSI.org iSCSI Target Core Stack
> > v3.0.0 on Linux/ppc64 on 2.6.26-rc3
> > Jun 4 23:26:16 cell kernel: SE: fp_auto_assign: 0
> > Jun 4 23:26:16 cell kernel: iscsi_target_detect:1075: ***ERROR***
> > create_proc_info_entry() failed.
> > "
> > Can you possible help with this problem ?
> >
>
> Ok, so when I was working on this last week, I was using kernel.org for
> patching and compiling. And did not quite get to testing it just yet.
>
> Anyways, lemme get v3.0 into a v2.6.23-rc3 VM this afternoon and make
> sure that things work as expected and I will resolve this PROC breakage
> too.
>

Ok, I think I was just missing the mode parameter for proc_create_data()

here in the commit:

http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=881e8547f915db98ee525400c5f0778cbb17ebfe

I am still trying to clone my tree to a VM here, so I have not been able
to test just yet, but I think the change should get you moving.

--nab

Nicholas A. Bellinger

unread,
Jun 5, 2008, 10:57:58 PM6/5/08
to linux-iscsi...@googlegroups.com, markbirss
On Thu, 2008-06-05 at 13:11 -0700, Nicholas A. Bellinger wrote:
> Hi again,
>
> On Thu, 2008-06-05 at 12:12 -0700, Nicholas A. Bellinger wrote:
> > Hi Mark!
> >
> > On Thu, 2008-06-05 at 10:22 -0700, markbirss wrote:
> > > Nab
> > >
> > > I obtained a git copy of lio-core-2.6 but have the follow kernel
> > > error:
> > >
> > > "
> > > Jun 4 23:26:16 cell kernel: Linux-iSCSI.org iSCSI Target Core Stack
> > > v3.0.0 on Linux/ppc64 on 2.6.26-rc3
> > > Jun 4 23:26:16 cell kernel: SE: fp_auto_assign: 0
> > > Jun 4 23:26:16 cell kernel: iscsi_target_detect:1075: ***ERROR***
> > > create_proc_info_entry() failed.
> > > "
> > > Can you possible help with this problem ?
> > >
> >
> > Ok, so when I was working on this last week, I was using kernel.org for
> > patching and compiling. And did not quite get to testing it just yet.
> >
> > Anyways, lemme get v3.0 into a v2.6.23-rc3 VM this afternoon and make
> > sure that things work as expected and I will resolve this PROC breakage
> > too.
> >
>
> Ok, I think I was just missing the mode parameter for proc_create_data()
>
> here in the commit:
>
> http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=881e8547f915db98ee525400c5f0778cbb17ebfe
>
> I am still trying to clone my tree to a VM here, so I have not been able
> to test just yet, but I think the change should get you moving.
>

Ok, I finally got a chance to get this compiled and loaded in a
v2.6.26-rc3 VM. The issue was actually the passing of
"proc_dir/proc_entry" for the first parameter of proc_create_data().

Here is the new commit:

http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=7e72152a264ad91199fb2cb02b471b036ee7f726

Please let me know if you run into any other problems.

Thanks!

--nab

Nicholas A. Bellinger

unread,
Jun 9, 2008, 3:52:38 PM6/9/08
to Mark Birss, Linux-iSCSI.org Target Dev
Hi Mark,

On Mon, 2008-06-09 at 10:36 +0200, Mark Birss wrote:
> Hi Nicholas
>
> I was able to build lio target-modules, but have problem building target-utils.
>
> I need some help with a in a form of a guide to build on ps3
>
> I did get a git copy of 2.6 which other sources do I require
>
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/nab/lio-core-2.6.git
> lio-core-2.6
>

Please follow the existing BUILD howto for target-utils v2.9 for use
with LIO-Core v3.0

http://linux-iscsi.org/svn/trunk/README

Please let me know if you have any more questions!

:-)

--nab

>
> Regards
>
>
> On Fri, Jun 6, 2008 at 8:57 AM, Mark Birss <mark...@gmail.com> wrote:
> > Hi Nab
> >
> > Thank you, will try this weekend.
> > Will let you know if I have any issues.
> >
> > Kind Regards
> > Mark
> >
> > On Fri, Jun 6, 2008 at 4:57 AM, Nicholas A. Bellinger

Nicholas A. Bellinger

unread,
Jun 9, 2008, 4:01:02 PM6/9/08
to linux-iscsi...@googlegroups.com, Mark Birss
On Mon, 2008-06-09 at 12:52 -0700, Nicholas A. Bellinger wrote:
> Hi Mark,
>
> On Mon, 2008-06-09 at 10:36 +0200, Mark Birss wrote:
> > Hi Nicholas
> >
> > I was able to build lio target-modules, but have problem building target-utils.
> >
> > I need some help with a in a form of a guide to build on ps3
> >
> > I did get a git copy of 2.6 which other sources do I require
> >
> > git clone git://git.kernel.org/pub/scm/linux/kernel/git/nab/lio-core-2.6.git
> > lio-core-2.6
> >
>
> Please follow the existing BUILD howto for target-utils v2.9 for use
> with LIO-Core v3.0
>
> http://linux-iscsi.org/svn/trunk/README
>
> Please let me know if you have any more questions!
>

Also, if you would like to create a step-by-step list of what you have
done on your PS3, I bet that alot of people would benefit from it.
Would you be interested in doing something like this on
Linux-iSCSI.org..?

--nab

Nicholas A. Bellinger

unread,
Jun 10, 2008, 11:41:44 PM6/10/08
to Mark Birss, Linux-iSCSI.org Target Dev
On Tue, 2008-06-10 at 11:47 +0200, Mark Birss wrote:
> Hi Nicholas
>
> I will certainly be willing to share my efforts once I'm done. The
> outcome that I want to achieve is to be able to export the Blu-ray
> drive over ISCSI to a Windows PC.
>

Great!!


> I'm building on Ubuntu. Does it support ./autoconfig ?
>

Yes.

> I have not yet finished with the Debian build instructions yet
> "
> DPKG Based (Debian/Ubuntu):
>
> cd target ; debian/rules binary
>

Yes, this will create the target-source for m-a (see below) and
target-utils package.

> This will generate target-source*.deb (for use with module-assistant)
> and target-utils*.deb in ../target/. After installing both of these
> packages, the target module can be compiled and installed with:
>
> m-a -vt a-i target
> "
>

Ok, so if you where to use the mentioned target-source above with m-a,
this would be packaging source from Linux-iSCSI.org SVN @ trunk/target f
or v2.9-STABLE, which works up to kernel v2.6.25 currently.

If you want to use lio-core-2.6.git (currently @ v2.6.26-rc2) for
LIO-Core v3.0-UPSTREAM on the PS3, using this kernel (which is
completely stock v2.6.26-rc2, the LIO-Core is located in
linux/drivers/lio-core/ and require no changes. To install this kernel,
follow the normal procedure as if you where building for ps3-linux.git,
and iscsi_target_mod.ko will be installed with 'make modules_install'
and should work fine with r346 target-utils .deb.

I watching some iSCSI/HD recently with my PS3 @ v2.6.25 + LIO
v2.9-STABLE, and next day or two I will put lio-core-2.6.git on my own
PS3. But everything should work as expected for you now, so go ahead
and try (with either tree) and let me know what you find.

--nab


> I see that target-utils is listed above. Is the target-utils the
> userspace packages ?
>
> Regards
>
>
> On Mon, Jun 9, 2008 at 10:01 PM, Nicholas A. Bellinger

Nicholas A. Bellinger

unread,
Jun 11, 2008, 12:17:10 AM6/11/08
to linux-iscsi...@googlegroups.com, Mark Birss

Actually, I merged to kernel v2.6.26-rc5 for lio-core-2.6.git, and in
the process of pulling now to my PS3 running Fedora 8. Lets see what
happens.. :-)

Nicholas A. Bellinger

unread,
Jun 11, 2008, 1:45:05 AM6/11/08
to Mark Birss, Linux-iSCSI.org Target Dev
On Wed, 2008-06-11 at 06:46 +0200, Mark Birss wrote:
> Nicholas
>
> Things are starting to become more clear...
>
> I have each time been getting a git copy only. This builds on my ps3
> but it does not include the iscsi-target-utils ? The kernel module (
> linux/drivers/lio-core) does compile. (I have loaded it) However
> this does not have a autoconf

Sorry, by autoconf I meant the LIO buildtools/autoconfig.master (which
is symlinked in trunk/target/autoconfig to generate
trunk/target/.make_autoconfig.

>
> I have been doing this:
> --------------------------------------------------
> cd /usr/src
>
> (my git copy /usr/src/lio-core-2.6)
>
> cd /usr/src/lio-core-2.6
>
> make ps3_defconfig
>
> make deb-pkg
> or
> /usr/share/kernel-package/rules build
>
> ---------------------------------------------------
>
> I will get the svn iscsi target/truck, to get the iscsi utils.
>

Yeah, you can do a debian/rules binary to create the target-utils.deb,
or simply do a make install.

Btw, I commited a small script fix that was
causing /etc/iscsi/install.target to be convered to v1 target-ctl calls
(eg: legacy stuff) when calling init.d/target start on my PS3.

I am not however unable to run any target-ctl commands on v2.6.26-rc5
because it appears that the ioctl32() is broken somewhere. As I am
running FC8 32-bit PPC userspace, I am currently running into this
issue. I am not sure if this is actual kernel development breakage, or
breakage in lio-core-2.6.git, as this worked fine with v2.9-STABLE on
v2.6.25.

I assume on ubuntu you are using a 32-bit userspace as well, so you are
going to be hung up on this for v3.0 for now.. If you are running
64-bit userspace, it will probably work just fine. In any event, I will
see if I can track down the breakage..

--nab

> Will inform you of my progress.
>
> Regards
>
>
>
> On Wed, Jun 11, 2008 at 6:17 AM, Nicholas A. Bellinger

Nicholas A. Bellinger

unread,
Jun 11, 2008, 3:38:48 AM6/11/08
to linux-iscsi...@googlegroups.com, Mark Birss
Hi Mark,

Ok, I am up and running on v2.6.26-rc5, here, is the commit to fix
(actually remove) the legacy ioctl32_conversion bits that we used to use
on the v2.4 and v2.2 days with LIO-Target.

http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=94807ca83fda6345a476749ec03e3739d4b38801

:-)

--nab

--------------------------[Session Info for TPGT: 1]--------------------------
iSCSI Target Portal Group: 1 iSCSI sessions active on TPG: 1
InitiatorName: iqn.1991-05.com.microsoft:nab-915f464a8de
InitiatorAlias:
iSBE Session ID: 1 ISID: 0x40 00 01 37 00 00 TSIH: 1 SessionType: Normal
Cmds in Session Pool: 3 Session State: TARG_SESS_LOGGED_IN
---------------------[iSCSI Session Values]-----------------------
CmdSN/WR : CmdSN/WC : ExpCmdSN : MaxCmdSN : ITT : TTT
0x00000010 0x00000010 0x00000131 0x00000140 0x00000130 0x000000e2
----------------------[iSCSI Connections]-------------------------
CID: 1 Connection State: TARG_CONN_LOGGED_IN
Address 192.168.0.110 TCP StatSN: 0x00000133
inst dev indx LUN lu_name vend prod rev dev_type status state-bit num_cmds read_mbytes write_mbytes rests full_stat hs_num_cmds creation_time
1 1 1 0 None SONY PS-SYSTEM 302R 4094 5 available exposed 61 0 0 0 0 0 9127
3 3 1 0 sn.73b073c4e157:2_2 LIO-ORG FILEIO v3.0 0 available exposed 0 0 0 0 0 0 9155
3 4 1 0 sn.73b073c4e157:2_3 LIO-ORG FILEIO v3.0 0 available exposed 0 0 0 0 0 0 9162
3 5 1 0 sn.73b073c4e157:2_4 LIO-ORG FILEIO v3.0 0 available exposed 0 0 0 0 0 0 9167
4 2 1 0 None TOSHIBA DVD/HD X807616 MC08 5 available exposed 243 0 0 0 0 0 9134
[root@ps3-cell ~]# cat /
[root@ps3-cell ~]# uname -a
Linux ps3-cell 2.6.26-rc5 #2 SMP Wed Jun 11 00:07:44 PDT 2008 ppc64 ppc64 ppc64 GNU/Linux
[root@ps3-cell ~]# cat /proc/iscsi_target/mib/inst_attr
inst min_ver max_ver portals nodes sessions fail_sess fail_type fail_rem_name disc_time
1 0 0 1 1 1 0 0 None 0
2 0 0 1 1 0 0 0 None 0
description: Storage Engine Target
vendor: Linux-iSCSI.org
version: v3.0.0 on Linux/ppc64
[root@ps3-cell ~]# cat /proc/iscsi_target/mib/scsi_inst
inst sw_indx
1 1
plugin: pscsi version: v3.0.0
3 1
plugin: fileio version: v3.0.0
4 1
plugin: pscsi version: v3.0.0
5 1
plugin: iblock version: v3.0.0
[root@ps3-cell ~]#

Reply all
Reply to author
Forward
0 new messages