You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to lint-dev
Currently, checkDependencies doesn't work on the app module with dynamic-feature modules. It will check upstream dependencies, but not the downstream dynamic modules. See https://issuetracker.google.com/issues/113198298#comment5
Tor Norbye
unread,
Jan 11, 2019, 11:05:28 AM1/11/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to lint-dev
On Tuesday, January 8, 2019 at 9:06:31 PM UTC-8, Alex Saveau wrote:
Currently, checkDependencies doesn't work on the app module with dynamic-feature modules. It will check upstream dependencies, but not the downstream dynamic modules. See https://issuetracker.google.com/issues/113198298#comment5
Yes, we should support that. It looks like in this example there's some code running during the build (https://github.com/SUPERCILEX/Robot-Scouter/blob/0f2b9c8f562b2e8aa79f5a738fb0f321c067e60f/app/android-base/build.gradle.kts#L13-L15) which produces a set of dependencies; lint has trouble statically analyzing arbitrary code that runs (it's basically the halting problem, though of course we have a lot of pattern matching to find common problems in code). On the other hand, if that code is executed such that the dependency model lint is handed includes them, lint should be able to see it and handle it properly.
-- Tor
Wim Bervoets
unread,
May 29, 2019, 1:11:24 PM5/29/19
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to lint-dev
Any update about the support for dynamic feature modules, now that dynamic features are out of beta?
The UnusedResources lint check thinks that drawable and strings are unused (in my core module), but they are used in the dynamic feature modules (package name prefixed R import)