Testsuite fails with -DDISABLE_COMMENTATOR

10 views
Skip to first unread message

Volker Braun

unread,
Aug 15, 2012, 7:25:26 PM8/15/12
to linbo...@googlegroups.com
The dummy LinBox::Commentator::report() method has no default arguments when one compiles with -DDISABLE_COMMENTATOR. But the linbox testssuite calls just report(). Hence its not possible to compile the testsuite with -DDISABLE_COMMENTATOR. 

Also, the tests/Makefile.am contains:

AM_LDFLAGS = $(top_srcdir)/linbox/.libs/liblinbox.a

This file doesn't exist if one does "configure -ddisable-static". At the very least, this should read

AM_LDFLAGS = $(top_srcdir)/linbox/liblinbox.la



B Saunders

unread,
Aug 15, 2012, 11:11:26 PM8/15/12
to linbo...@googlegroups.com
Hi, Volker,

I've fixed the null commentator (in svn version 4370).

It seems that the AM_LDFLAGS is already changed as you suggest in the svn version.

Thanks for these suggestions!

Best,
-dave

--
B. David Saunders, 302-831-6238
CIS Department, University of Delaware





--
You received this message because you are subscribed to the Google Groups "linbox-use" group.
To view this discussion on the web visit https://groups.google.com/d/msg/linbox-use/-/poh88zhINJgJ.
To post to this group, send email to linbo...@googlegroups.com.
To unsubscribe from this group, send email to linbox-use+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/linbox-use?hl=en.

Volker Braun

unread,
Aug 16, 2012, 12:17:44 AM8/16/12
to linbo...@googlegroups.com
That was fast, thanks!
Reply all
Reply to author
Forward
0 new messages