hadamard-bound.h not installed

[Paul Gunnells]

Hello,

Thanks to the help on ffpack-devel I now have linbox installed and working.  I was able to successfully compile some of the sample programs outside the repo with a home-rolled makefile.  However when I tried to compile smithvalence.C, it failed when it couldn't locate hadamard-bound.h:

gunnells$ make smithvalence

g++ -I-O2 -Wall -g -DNDEBUG -U_LB_DEBUG -DDISABLE_COMMENTATOR -fopenmp -std=gnu++11 -fabi-version=6 -std=gnu++11 -fabi-version=6 -I/home/gunnells/include -o smithvalence smithvalence.C -L/home/gunnells/lib -llinbox -lntl -liml -fopenmp -lopenblas -Wl,-rpath,/home/gunnells/lib -lgivaro -lgmp -lgmpxx

In file included from /home/gunnells/include/linbox/algorithms/rational-solver.inl:37:0,

                 from /home/gunnells/include/linbox/algorithms/rational-solver.h:1051,

                 from /home/gunnells/include/linbox/algorithms/rational-solver-adaptive.h:34,

                 from /home/gunnells/include/linbox/algorithms/smith-form-adaptive.inl:40,

                 from /home/gunnells/include/linbox/algorithms/smith-form-adaptive.h:106,

                 from /home/gunnells/include/linbox/solutions/smith-form.h:34,

                 from smithvalence.C:39:

/home/gunnells/include/linbox/algorithms/lifting-container.h:52:45: fatal error: linbox/solutions/hadamard-bound.h: No such file or directory

Indeed it looks like "make install" doesn't install this, as far as I can tell:

gunnells$ make install

...

Making install in solutions

make[2]: Entering directory '/home/gunnells/linbox/linbox/solutions'

make  install-exec-am install-data-am

make[3]: Entering directory '/home/gunnells/linbox/linbox/solutions'

make[3]: Nothing to be done for 'install-exec-am'.

:

list='charpoly.h det.h getentry.h getentry.inl is-positive-definite.h is-positive-semidefinite.h methods.h minpoly.h nullspace.h rank.h rank.inl smith-form.h solve.h trace.h trace.inl valence.h solution-tags.h'; test -n "/home/gunnells/include/linbox/solutions" || list=

; \

It doesn't look like hadamard-bound.h is there.  When I copied over hadamard-bound.h over by hand smithvalence.C compiled with no problem.

-Paul

[Jean-Guillaume Dumas]

On 12/02/2019 02:27, Paul Gunnells wrote:
> Hello,
>
> Thanks to the help on ffpack-devel I now have linbox installed and
> working.  I was able to successfully compile some of the sample
> programs outside the repo with a home-rolled makefile.  However when I
> tried to compile smithvalence.C, it failed when it couldn't locate
> hadamard-bound.h:
>

> It doesn't look like hadamard-bound.h is there.  When I copied over
> hadamard-bound.h over by hand smithvalence.C compiled with no problem.

Dear Paul Gunnells, thank you very much for the report.

This is now fixed in the repository.

Regards,

--
Jean-Guillaume Dumas.
____________________________________________________________________
Jean-Guill...@univ-grenoble-alpes.fr Tél.: +33 457 421 732
Professeur, Université Grenoble Alpes. Fax.: +33 457 421 828
Laboratoire Jean Kuntzmann, Mathématiques Appliquées et Informatique
700 avenue centrale, IMAG - CS 40700, 38058 GRENOBLE cedex 9, FRANCE
http://ljk.imag.fr/membres/Jean-Guillaume.Dumas
____________________________________________________________________