Hi,
Thanks Dave for orgnazing this.
I agree on almost every point you propose.
Let me comment on those where I either disagree or that I have fixed:
> I say move to attic. OK?
> test-ffpack skipped, testTURBO fails, move to ffpack tests?
I fixed the TURBO test pb (TURBO is deprecated and moved to fflas-ffpack attic). But the rest of the
test kind of make sense though (even if it is redundant with fflas-ffpack test-suite). I wouldn't
mind keeping it here, as a fullcheck target (even maybe a basic check target), as long as I did not
sit down and made sure that all tests in it are already done in fflas-ffpack test-suite.
> test-ftrmm skipped, should move to fflas tests?
It was already moved and improved. It should definitely be moved to the attic
> Move to attic?
> test-givaro-zpz build OK, run OK. tested in Givaro?
> test-givaro-zpzuns build OK, run OK. tested in Givaro?
These 2 tests should stay for they test the integration of these Givaro fields in LinBox. In
particular whether the archetype/enveloppe mechanism works on them.
This is currently broken (issue #7:
https://github.com/linbox-team/linbox/issues/7 )
So it should be moved to category "Needs work"
> test-rat-minpoly skipped, stale test. solns over QQ need fresh tests
> test-rat-solve skipped, stale test. solns over QQ need fresh tests
The whole QQ part of LinBox is in a terrible state: either badly tested or tests fail or loop
infinitly. Let's try to fix it or disable it for the 1.4.0 release.
>
> Keep, but exclude from fullcheck
> test-la-block-lanczos skipped, not maintained. operator >> missing
> test-mg-block-lanczos skipped, not maintained
> test-sparse-map-map skipped, curious use of nonexistant next() in Extension
Ok. I wouldn't mind moving the whole block-lanczos to the attic. Nobody stepped in to fix it since
>8 years, so it's probably going to stay there unfinished and confuse users.
>
> Needs work
> test-blas-domain build FAIL
I've fixed it.
> *test-blas-matrix build OK, run OK. intermittently fails
I've fixed it.
> test-charpoly build FAIL
It does not fail on my side. Do you confirm it is fixed for you?
> test-dyadic-to-rational build FAIL
> test-fibb build OK, run FAIL
> test-gf2 build OK, run OK. not much is tested there
> test-last-invariant-factor build FAIL
Not seing any FAIL on my side.
> test-matrix-domain build OK, run OK. intermittent row permutation failure
Should be fixed now. Doesn't fail on my side.
> test-modular-balanced-double skipped, test and modular-balanced disagree on init/convert
> test-modular-balanced-int skipped, test and modular-balanced disagree on init/convert
> test-moore-penrose skipped, inf loop
> test-ntl-rr build OK, run FAIL
> test-ntl-zz_p build FAIL
This one always passes on my side.
> test-order-basis build OK, run FAIL
This one passes on my side (but with unwanted verbosity, Pascal, can you fix it?).
> test-poly-det build FAIL
This test looks totally unfinished (call to a missing function, missing license info, etc).
If this is work in progress that was never finished, we should move to the attic.
> test-qlup build OK, run FAIL
This is issue #10. JG, I added you as assignee, as it is mostly about code that you wrote.
> *test-rank-u32 skipped, intermittent error
Never seen it fail.
> *test-rat-charpoly skipped, inf loop
See my remark on QQ above. This one should be treated as test-rat-minpoly.
Clément