Preparing a patch for vim-7.2?

[Mikael Jansson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Heya,

Time to prepare a patch to send off to vim_dev? I've looked at the code
while doing the initial merge and it seemed fine then.

The patch against 7.2::

$ svn diff \
https://svn.jansson.be/limp/vim-ecl/7.2 \
https://svn.jansson.be/limp/vim-ecl/vim

Could I get a second pair of eyes looking through it and see if it's OK?
I'd like us to push it upstream as soon as possible!

- - Mikael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFI3meCs8liwIiYZggRAlqZAKCrj4yJIfgB+QI7Dtia+4ZvWdeEaQCg5ttk
KHxcGrHgTChjLjntgNfgGR8=
=ZHQE
-----END PGP SIGNATURE-----

[Si]

Absolutely! I hope to find time for this tonight.

[Si]

I ended up having less time than I thought!

Still... patch applied cleanly (-p0 against https://svn.jansson.be/limp/vim-ecl/7.2
with diff generated as per above command), build and test successful.

I think the only issues I see are very minor - whitespace (e.g.
if_ecl.c, and possible tab / space mixing elsewhere) and po diff
errors at the diff's tail, which we could exclude from patch of course.

[Si]

I'll take a look at the Lisp code in more detail as soon as I can.

On Sep 29, 12:22 am, Si <simon.peter.nicho...@googlemail.com> wrote:
> I ended up having less time than I thought!
>

> Still... patch applied cleanly (-p0 againsthttps://svn.jansson.be/limp/vim-ecl/7.2

[Mikael Jansson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Great!

- -- Mikael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFI4GQjs8liwIiYZggRAov+AJ9camBdRZNZHbmqg9zyGxs2RvGVWwCgsVTR
8qgB8DJfloMucOwq3RD3ud8=
=AcXf
-----END PGP SIGNATURE-----

[Si]

I'm certainly no expert, but it looks good to me!

[Mikael Jansson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Si wrote:
> I'm certainly no expert, but it looks good to me!
>

Alright. I'll look through it again and try to package it. Worst thing
that can happen is that it gets refused, we get comments on, fix stuff
and submit again!

- -- Mikael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFI5Ujos8liwIiYZggRAjkTAJwNBybsnSYaWqFtI49CrAUlDJvdcwCgoY0w
uDTYKBbdH7N4zjZoUBo9R80=
=5Orl
-----END PGP SIGNATURE-----

[Si]

Cool. I'm game to help with any fixes etc of course.

[Mikael Jansson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Si wrote:
> Cool. I'm game to help with any fixes etc of course.

... and on that note:

http://groups.google.com/group/vim_dev/browse_thread/thread/bdf65d24b6305c3f#

- -- Mikael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJAtqSs8liwIiYZggRAqcXAKCV6adGC0GXlKGqwAUUAbilxAKB+ACglAwt
l41uoRQBMzcompBl8iMhNIA=
=xpPK
-----END PGP SIGNATURE-----