some jars not works well as bundles

34 views

Skip to first unread message

Guofeng Zhang

unread,

Dec 28, 2011, 4:40:21 AM12/28/11

to liftweb

Hi,

I deployed liftweb jars files as bundles to Felix framwrok 4.0.2. I find that the some bundles’ MANIFEST.MF are not generated correctly.

1. lift-webkit

(a) it exports and imports the following packages:

Export-Package:net.liftweb.mocks,org.specs.specification,org.specs

Import-Package:net.liftweb.mocks,org.specs,org.specs.specification

but these package are not packaged in the jar, so they should be removed from the import and export directive.

(b) I have set LiftRules.getResource to load the templates from the web application bundle. The template is found but I got the error said “Expected ';'” (see the stack track at the end of the mail). I use HTML 5 and use Validator.nu (X)HTML5 Validator to check my template. It does not have error missing “;” (only has error said the row in table is defined improperly).

If I add “<DynamicImport-Package>*</DynamicImport-Package>” to the MANIFEST.MF, the template is displayed without problem.

So I think the MANIFEST.MF should also has <DynamicImport-Package>*</DynamicImport-Package> added, but I cannot figure out why. Your advice is appreciated.

2. lift-util

It exports and imports the following packages:

Export-Package:org.apache.log4j,org.apache.log4j.xml,org.apache.log4j.spi

Import-Package:org.apache.log4j,org.apache.log4j.xml,org.apache.log4j.spi

It should be removed.

Because ClassHelpers use Class.forName() for resources or templates, so it should add the following in its MANIFEST.MF

<DynamicImport-Package>*</DynamicImport-Package>

3. lift-commons

it should import ch.qos.logback’s package optionally, or it will affect the OSGi framework’s log service. It should not initialize logback in such environment.

That is, its Import-Package directive should be:

ch.qos.logback.classic;resolution:=optional,

ch.qos.logback.core;resolution:=optional,

ch.qos.logback.core.util;resolution:=optional,

ch.qos.logback.classic.joran;resolution:=optional

……

(b)’s stacktrack:

<div>

Error locating template:

/index.html

Message:

Expected ';'

<pre>

java.lang.RuntimeException: Expected ';'scala.sys.package$.error(package.scala:27)

scala.xml.parsing.MarkupParserCommon$class.takeUntilChar(MarkupParserCommon.scala:85)

scala.xml.parsing.MarkupParserCommon$class.normalizeAttributeValue(MarkupParserCommon.scala:145)

scala.xml.parsing.MarkupParserCommon$class.xAttributeValue(MarkupParserCommon.scala:76)

net.liftweb.util.PCDataXmlParser.xAttributeValue(PCDataMarkupParser.scala:98)

net.liftweb.util.PCDataXmlParser.xAttributes(PCDataMarkupParser.scala:113)

scala.xml.parsing.MarkupParser$class.mkAttributes(MarkupParser.scala:261)

net.liftweb.util.PCDataXmlParser.mkAttributes(PCDataMarkupParser.scala:98)

scala.xml.parsing.MarkupParserCommon$class.xTag(MarkupParserCommon.scala:44)

net.liftweb.util.PCDataXmlParser.xTag(PCDataMarkupParser.scala:98)

scala.xml.parsing.MarkupParser$class.element1(MarkupParser.scala:528)

net.liftweb.util.PCDataXmlParser.element1(PCDataMarkupParser.scala:98)

scala.xml.parsing.MarkupParser$class.content1(MarkupParser.scala:396)

net.liftweb.util.PCDataXmlParser.content1(PCDataMarkupParser.scala:98)

scala.xml.parsing.MarkupParser$class.content(MarkupParser.scala:417)

net.liftweb.util.PCDataXmlParser.content(PCDataMarkupParser.scala:98)

scala.xml.parsing.MarkupParser$class.element1(MarkupParser.scala:542)