workstatus message bug w/patch

[Chris Liebman]

I noticed that workstatus messages have the input file key set to the
output file key.... I found that MessageHelper.createServiceStatus
uses a reference to the workrequests FileRef which is modified for the
next part of the workflow before the status message is sent. Also
the output bucket was not set. Proposed patch:

--- java/com/directthought/lifeguard/MessageHelper.java 6 Jun 2008
14:45:41 -0000 1.1.1.1
+++ java/com/directthought/lifeguard/MessageHelper.java 17 Jul 2008
16:25:48 -0000
@@ -58,10 +58,15 @@
ret.setBatch(wr.getBatch());
ret.setServiceName(wr.getServiceName());
ret.setInputBucket(wr.getInputBucket());
- ret.setInput(wr.getInput());
+ FileRef ref = of.createFileRef();
+ ref.setKey(wr.getInput().getKey());
+ ref.setType(wr.getInput().getType());
+ ref.setLocation(wr.getInput().getLocation());
+ ret.setInput(ref);
+ ret.setOutputBucket(wr.getOutputBucket());
if (outFiles != null) {
for (MetaFile file : outFiles) {
- FileRef ref = of.createFileRef();
+ ref = of.createFileRef();
ref.setKey(file.key);
ref.setType(file.mimeType);
ref.setLocation("S3");

[David Kavanagh]

Chris, Sorry it took so long.. back into lifeguard work after vacation
though. This is in SVN r80