Qt5

[Erik Johansson]

Hi,

After reading http://perezmeyer.blogspot.se/2014/09/qt5-in-jessie-we-will-release-with-532.html I thought it might be good to start port qt4-gui to Qt5. I've started a quick'n'dirty conversion and I have pushed a qt5 branch to github. It builds and seems to work.

Comments welcome.

// Erik

--
Erik Johansson
Home Page: http://ejohansson.se/
PGP Key: http://ejohansson.se/erik.asc

[Anders Olofsson]

Good!

I had a quick look and the only thing I don't like is that you remove
the kde-gui. Do you know if KDE will move to Qt5 as well before Jessie
releases?

I think the name change to qt-gui can be done immediately and regardless
of the Qt version switch. I'll push the rename (but without the switch
to Qt5) to master as soon as I've gone through and updated all the
README's and comments that refers to the qt4-gui.
I will also look at the code changes you did to make it build. I would
guess most of them can be done for Qt4 and can go on master right away.

/Anders

> --
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Licq Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to licq-dev+u...@googlegroups.com
> <mailto:licq-dev+u...@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout.

[Kevin Krammer]

On Saturday, 2014-10-04, 10:27:12, Anders Olofsson wrote:
> Good!
>
> I had a quick look and the only thing I don't like is that you remove
> the kde-gui. Do you know if KDE will move to Qt5 as well before Jessie
> releases?

It is unlikely that Jessie will include the Qt5 based version of KDE Plasma,
the workspace product, if that is what you mean with "KDE".

Cheers,
Kevin

[Anders Olofsson]

In that case I'm against moving to Qt5 at this time as it would require
losing the KDE version of the GUI and I'm assuming Qt4 will not be
deprecated for some time yet.

However if it can be possible to build with both Qt4 and Qt5 from the
same branch without making the code too awkward then I have no problem
with having Qt5 support on master.

/Anders

[Erik Johansson]

Hi,

On 4 October 2014 10:27, Anders Olofsson <fl...@licq.org> wrote:

I had a quick look and the only thing I don't like is that you remove the kde-gui. Do you know if KDE will move to Qt5 as well before Jessie releases?

After looking around a bit more it seems like they will try to drop Qt4 in Jessie+1. So no rush getting Qt4 out.

 

I think the name change to qt-gui can be done immediately and regardless of the Qt version switch. I'll push the rename (but without the switch to Qt5) to master as soon as I've gone through and updated all the README's and comments that refers to the qt4-gui.
I will also look at the code changes you did to make it build. I would guess most of them can be done for Qt4 and can go on master right away.

Looks good. I've actually started working on getting Qt5 support to co-exist with Qt4 as you wrote in another mail.

After it builds we should look into all uses of Q_WS_X11 since that define isn't used in Qt5.

// Erik

 

[Erik Johansson]

On 5 October 2014 22:49, Anders Olofsson <fl...@licq.org> wrote:

However if it can be possible to build with both Qt4 and Qt5 from the same branch without making the code too awkward then I have no problem with having Qt5 support on master.'

Qt5 support landed on master just now. Enable by building with -DWITH_QT5=ON.

// Erik