Release soon?

[Marco Rogers]

Hey, shall we do another release soon? I wanna get more familiar with the new gyp stuff and run through my own sanity checks on 0.7 of node. I can spend some time updating the docs too.

We should probably decide if we're taking the 2 open pull requests too. It's still on me to look over the xmlwriter stuff. I'd take the CDATA thing with tests. But the OP may not actually do it. Any volunteers?

https://github.com/polotek/libxmljs/pull/124

https://github.com/polotek/libxmljs/pull/104

:Marco

[Nicholas Campbell]

I added a test for 124. I merged the pull request and pushed that plus
the test up to master.

We may want to consider the api choice with the cdata. At the moment,
adding cdata is done by calling `.cdata()` on an element. It seems
that a more consistent api would be `.addCData()` while using
`.cdata()` to explicitly retrieve the cdata from the element itself.

Thoughts?

- Nick Campbell

http://digitaltumbleweed.com

[Nicholas Campbell]

So, I looked a little closer at the Element.js code and the cdata api
is consistent with the other functions. In fact, `.cdata()` works like
the `.node()` api.

It doesn't seem like using `.cdata()` to get the cdata would matter
since you can get the element and then the text of the element. So,
yea, I think the API is fine.

- Nick Campbell

http://digitaltumbleweed.com

[Marco Rogers]

Cool. I'll spend some time on the docs this week.

--
Marco Rogers
marco....@gmail.com | https://twitter.com/polotek

Life is ten percent what happens to you and ninety percent how you respond to it.
- Lou Holtz

[Murat Atak]

5 Mayıs 2012 Cumartesi 02:12:20 UTC+3 tarihinde Marco Rogers yazdı:

generetion vast xml as a vast example
var temp_vast_xml = vast3_xml.node('VAST');

temp_vast_xml = temp_vast_xml.node('AdTitle', temp_vast_xml.cdata(AdTitle) );